Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Gecko FFI functions for color parsing to report errors #19490

Merged
merged 5 commits into from Dec 5, 2017
Merged

allow Gecko FFI functions for color parsing to report errors #19490

merged 5 commits into from Dec 5, 2017
+87 −19

Commits on Dec 5, 2017

  1. geckolib: Return from Servo_ComputeColor whether the value was curren… 

    …tcolor.
    @heycam
    heycam committed Dec 5, 2017
    393ab5a

  2. geckolib: Allow an ErrorReporter to be created with null URL data. 

    This allows us to create an ErrorReporter that will report errors as being
"from DOM" rather than a specific URL.

Also, factor out a method on ErrorReporter so that we don't need to pass in
a UrlExtraData reference.
    @heycam
    heycam committed Dec 5, 2017
    7940061

  3. style: Add a new CSS error type for lone value parsing errors. 

    This allows us to report errors in functions that want to just parse a
single CSS value, rather than a value for a particular property declaration.

The one value type that we need to support for now is <color> value parsing
errors, so just add formatting/support for that.
    @heycam
    heycam committed Dec 5, 2017
    7015d5b

  4. geckolib: Allow Servo_ComputeColor to report errors to the console.

    @heycam
    heycam committed Dec 5, 2017
    9a31d0d

  5. style: Regenerate Gecko bindings.

    @heycam
    heycam committed Dec 5, 2017
    Loading status checks…
    64c5a8a
You can’t perform that action at this time.