Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for <input type=datetime> #19509

Merged
merged 1 commit into from Dec 7, 2017

Conversation

@jonleighton
Copy link
Contributor

jonleighton commented Dec 7, 2017

It has been removed from the spec: whatwg/html#336

See also #19471 (review)


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

It has been removed from the spec: whatwg/html#336

See also #19471 (review)
@highfive
Copy link

highfive commented Dec 7, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlinputelement.rs
  • @fitzgen: components/script/dom/htmlinputelement.rs
  • @KiChjang: components/script/dom/htmlinputelement.rs
@jonleighton
Copy link
Contributor Author

jonleighton commented Dec 7, 2017

r? jdm

@highfive highfive assigned jdm and unassigned nox Dec 7, 2017
@jdm
Copy link
Member

jdm commented Dec 7, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

📌 Commit 5ff4dc0 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

Testing commit 5ff4dc0 with merge 8e3056d...

bors-servo added a commit that referenced this pull request Dec 7, 2017
Remove support for <input type=datetime>

It has been removed from the spec: whatwg/html#336

See also #19471 (review)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19509)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

💔 Test failed - mac-rel-wpt1

@jdm
Copy link
Member

jdm commented Dec 7, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

@jonleighton
Copy link
Contributor Author

jonleighton commented Dec 7, 2017

Looks like that was a network error during the build, unrelated to this change

@jonleighton
Copy link
Contributor Author

jonleighton commented Dec 7, 2017

Ah, beat me to it ;)

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2017

@bors-servo bors-servo merged commit 5ff4dc0 into servo:master Dec 7, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.