Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove LRU cache behavior in SelectorFlagsMap #19512
Merged
+29
−43
Conversation
This code used to insert duplicate entries to avoid expensive shuffling of the LRU cache. With uluru this is no longer necessary, because reordering the cache is cheap. Now it uses the `LRUCache::find` method from uluru 0.2 to update entries in-place. This should improve the hit rate, because it eliminates unnecessary evictions.
highfive
commented
Dec 7, 2017
|
Heads up! This PR modifies the following files:
|
|
r? @emilio |
|
Nice! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 7, 2017
Improve LRU cache behavior in SelectorFlagsMap This code used to insert duplicate entries to avoid expensive shuffling of the LRU cache. With uluru this is no longer necessary, because reordering the cache is cheap. Now it uses the `LRUCache::find` method from uluru 0.2 to update entries in-place. This should increase cache hits by eliminating unnecessary evictions. This PR also updates `arrayvec` because `uluru` depends on it, and `immeta` because it depends on `arrayvec`. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they don't change behavior <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19512) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedDec 7, 2017
•
edited by SimonSapin
This code used to insert duplicate entries to avoid expensive shuffling of the LRU cache. With uluru this is no longer necessary, because reordering the cache is cheap.
Now it uses the
LRUCache::findmethod from uluru 0.2 to update entries in-place. This should increase cache hits by eliminating unnecessary evictions.This PR also updates
arrayvecbecauseulurudepends on it, andimmetabecause it depends onarrayvec../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is