Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP (Do not merge) Media stuff #19521

Closed
wants to merge 1 commit into from
Closed

WIP (Do not merge) Media stuff #19521

wants to merge 1 commit into from

Conversation

@nox
Copy link
Member

nox commented Dec 8, 2017

This change is Reviewable

@highfive
Copy link

highfive commented Dec 8, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs
  • @fitzgen: components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs
  • @KiChjang: components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs
@highfive
Copy link

highfive commented Dec 8, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Dec 8, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2017

Trying commit 032746b with merge 0479028...

bors-servo added a commit that referenced this pull request Dec 8, 2017
(Do not merge) Media stuff
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2017

💔 Test failed - linux-rel-wpt

WIP
@nox nox force-pushed the nox:media branch from 032746b to d15e049 Dec 8, 2017
@highfive highfive removed the S-tests-failed label Dec 8, 2017
@nox
Copy link
Member Author

nox commented Dec 8, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2017

📌 Commit d15e049 has been approved by nox

@highfive highfive assigned nox and unassigned mbrubeck Dec 8, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2017

Testing commit d15e049 with merge a0c96bd...

bors-servo added a commit that referenced this pull request Dec 8, 2017
(Do not merge) Media stuff

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19521)
<!-- Reviewable:end -->
@nox
Copy link
Member Author

nox commented Dec 8, 2017

@bors-servo r- try

bors-servo added a commit that referenced this pull request Dec 8, 2017
(Do not merge) Media stuff

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19521)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2017

Trying commit d15e049 with merge acd93c4...

@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2017

💔 Test failed - linux-rel-wpt

@KiChjang KiChjang changed the title (Do not merge) Media stuff WIP (Do not merge) Media stuff Dec 8, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jan 19, 2018

The latest upstream changes (presumably #19806) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm
Copy link
Member

jdm commented Jan 19, 2018

No more media.

@jdm jdm closed this Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.