Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFilter out failed test-perf runs. #19523
Merged
+3
−1
Conversation
highfive
commented
Dec 8, 2017
|
Heads up! This PR modifies the following files:
|
etc/ci/performance/runner.py
Outdated
| @@ -281,10 +281,12 @@ def save_result_csv(results, filename, manifest, expected_runs, base): | |||
| 'unloadEventStart', | |||
| ] | |||
|
|
|||
| successes = list(filter(lambda x: x['domComplete'] != -1, results)) | |||
This comment has been minimized.
This comment has been minimized.
aneeshusa
Dec 14, 2017
Member
List comprehensions are more idiomatic in Python:
successes = [r for r in results if r['domComplete'] != -1]
This comment has been minimized.
This comment has been minimized.
asajeffrey
Dec 18, 2017
Author
Member
Fixed. There's quite a few more of those :/ Time to file an E-Easy issue?
|
@asajeffrey looks good--can you squash please? |
|
Will do when I'm back in front of a computer. |
|
@asajeffrey status on this? |
asajeffrey
force-pushed the
asajeffrey:test-perf-filter-out-failed-tests
branch
from
b0775e1
to
fcc64cf
|
@avadacatavra er the status is Xmas holiday. I squashed. @bors-servo r=avadacatavra |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2018
…r=avadacatavra Filter out failed test-perf runs. <!-- Please describe your changes on the following line: --> Google Data Studio is a lot happier if the data that's driving it is already filtered. This PR filters out any failed test runs from the CSV file generated by test-perf. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because this is test infrastructure <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19523) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2018
…r=avadacatavra Filter out failed test-perf runs. <!-- Please describe your changes on the following line: --> Google Data Studio is a lot happier if the data that's driving it is already filtered. This PR filters out any failed test runs from the CSV file generated by test-perf. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because this is test infrastructure <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19523) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedDec 8, 2017
•
edited by SimonSapin
Google Data Studio is a lot happier if the data that's driving it is already filtered. This PR filters out any failed test runs from the CSV file generated by test-perf.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is