Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Rust 1.22.1 for geckolib #19532
Merged
Use Rust 1.22.1 for geckolib #19532
Conversation
This matches the version required for Firefox builds: https://bugzilla.mozilla.org/show_bug.cgi?id=1421097
highfive
commented
Dec 9, 2017
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 9, 2017
Use Rust 1.22.1 for geckolib This matches the version required for Firefox builds: https://bugzilla.mozilla.org/show_bug.cgi?id=1421097 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19532) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 9, 2017
style: Use the ? operator for Option This is stable in Rust 1.22 (#19532). --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it is refactoring only <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19537) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedDec 9, 2017
•
edited by SimonSapin
This matches the version required for Firefox builds:
https://bugzilla.mozilla.org/show_bug.cgi?id=1421097
This change is