Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Use the ? operator for Option #19537

Merged
merged 1 commit into from Dec 9, 2017
Merged

style: Use the ? operator for Option #19537

merged 1 commit into from Dec 9, 2017

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 9, 2017 •
edited by SimonSapin

This is stable in Rust 1.22 (#19532).

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it is refactoring only

This change is Reviewable
@highfive
Copy link

highfive commented Dec 9, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets/origin.rs, components/style/custom_properties.rs, components/style/bloom.rs, components/style/style_resolver.rs, components/style/invalidation/element/element_wrapper.rs and 6 more
  • @canaltinova: components/style/stylesheets/origin.rs, components/style/custom_properties.rs, components/style/bloom.rs, components/style/style_resolver.rs, components/style/invalidation/element/element_wrapper.rs and 6 more
  • @emilio: components/style/stylesheets/origin.rs, components/style/custom_properties.rs, components/style/bloom.rs, components/style/style_resolver.rs, components/style/invalidation/element/element_wrapper.rs and 6 more
@highfive
Copy link

highfive commented Dec 9, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@mbrubeck mbrubeck force-pushed the mbrubeck:try branch from bd82fdf to 3ddf988 Dec 9, 2017
@nox
Copy link
Member

nox commented Dec 9, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2017

📌 Commit 3ddf988 has been approved by nox
@highfive highfive assigned nox and unassigned cbrewster Dec 9, 2017
@mbrubeck
style: Use the ? operator for Option
Loading status checks…
3005a26
@mbrubeck mbrubeck force-pushed the mbrubeck:try branch from 3ddf988 to 3005a26 Dec 9, 2017
@nox
Copy link
Member

nox commented Dec 9, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2017

📌 Commit 3005a26 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2017

⌛ Testing commit 3005a26 with merge 5f4f355...
bors-servo added a commit that referenced this pull request Dec 9, 2017
@bors-servo
Auto merge of #19537 - mbrubeck:try, r=nox
Loading status checks…
5f4f355 
style: Use the ? operator for Option

This is stable in Rust 1.22 (#19532).

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it is refactoring only

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19537)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2017

💔 Test failed - android
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Dec 9, 2017

@bors-servo retry

  • ?
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2017

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 5f4f355 to master...
@bors-servo bors-servo merged commit 3005a26 into servo:master Dec 9, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mbrubeck @highfive @nox @bors-servo @cbrewster
You can’t perform that action at this time.