Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mach: Fix cargo-geckolib check / cargo-geckolib build after #19476. #19539

Merged
merged 2 commits into from Dec 14, 2017
Merged

mach: Fix cargo-geckolib check / cargo-geckolib build after #19476. #19539

merged 2 commits into from Dec 14, 2017

Conversation

@emilio
Copy link
Member

emilio commented Dec 9, 2017 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Dec 9, 2017

Heads up! This PR modifies the following files:
@emilio
Copy link
Member Author

emilio commented Dec 9, 2017

r? @nox or @SimonSapin
@highfive highfive assigned nox and unassigned jdm Dec 9, 2017
@emilio
Copy link
Member Author

emilio commented Dec 9, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2017

⌛ Trying commit 16528bf with merge d7b1cbb...
bors-servo added a commit that referenced this pull request Dec 9, 2017
@bors-servo
Auto merge of #19539 - emilio:cargo-geckolib, r=<try>
Loading status checks…
d7b1cbb 
mach: Fix cargo-geckolib check / cargo-geckolib build after #19476.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19539)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2017

💔 Test failed - android
@SimonSapin
Copy link
Member

SimonSapin commented Dec 9, 2017

This doesn’t work in the general case of arbitrary cargo subcommands, since not all of them take -p.

Maybe something like this? https://github.com/servo/servo/pull/19395/files#diff-309c064985884bee5b85e07757ca0103R44
@emilio emilio force-pushed the emilio:cargo-geckolib branch from 16528bf to f789f5b Dec 10, 2017
@emilio
Copy link
Member Author

emilio commented Dec 10, 2017

Sounds good, just did that
@emilio
mach: Fix cargo-geckolib check / cargo-geckolib build after #19476.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
f2314c1
@emilio emilio force-pushed the emilio:cargo-geckolib branch from f789f5b to f2314c1 Dec 10, 2017
@SimonSapin
Copy link
Member

SimonSapin commented Dec 13, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2017

📌 Commit 94ffe02 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned nox Dec 13, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2017

⌛ Testing commit 94ffe02 with merge 5cec8cf...
bors-servo added a commit that referenced this pull request Dec 13, 2017
@bors-servo
Auto merge of #19539 - emilio:cargo-geckolib, r=SimonSapin
Loading status checks…
5cec8cf 
mach: Fix cargo-geckolib check / cargo-geckolib build after #19476.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19539)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2017

💔 Test failed - mac-rel-css2
@emilio
Copy link
Member Author

emilio commented Dec 13, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2017

⚡ Previous build results for android, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-dev, mac-rel-css2...
@emilio
mach: Remove redundant with(crate_dir).
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
5dfa144
@emilio emilio force-pushed the emilio:cargo-geckolib branch from 94ffe02 to 5dfa144 Dec 13, 2017
@emilio
Copy link
Member Author

emilio commented Dec 13, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2017

📌 Commit 5dfa144 has been approved by emilio
@highfive highfive assigned emilio and unassigned SimonSapin Dec 13, 2017
@emilio
Copy link
Member Author

emilio commented Dec 13, 2017

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #17580
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2017

📌 Commit 5dfa144 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned emilio Dec 13, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2017

⌛ Testing commit 5dfa144 with merge 2b87b0a...
bors-servo added a commit that referenced this pull request Dec 13, 2017
@bors-servo
Auto merge of #19539 - emilio:cargo-geckolib, r=SimonSapin
Loading status checks…
2b87b0a 
mach: Fix cargo-geckolib check / cargo-geckolib build after #19476.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19539)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2017

💔 Test failed - android
@emilio
Copy link
Member Author

emilio commented Dec 14, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2017

⌛ Testing commit 5dfa144 with merge 11d32d8...
bors-servo added a commit that referenced this pull request Dec 14, 2017
@bors-servo
Auto merge of #19539 - emilio:cargo-geckolib, r=SimonSapin
Loading status checks…
11d32d8 
mach: Fix cargo-geckolib check / cargo-geckolib build after #19476.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19539)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing 11d32d8 to master...
@bors-servo bors-servo merged commit 5dfa144 into servo:master Dec 14, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Dec 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @bors-servo @SimonSapin @jdm @nox
You can’t perform that action at this time.