Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that 'style' is compiled in a supported configuration. #19540

Merged
merged 1 commit into from Dec 10, 2017
Merged

Check that 'style' is compiled in a supported configuration. #19540

merged 1 commit into from Dec 10, 2017
+9 −0

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Dec 10, 2017 •
edited

Provide an explanatory error message when the compilation would fail because of missing or duplicate items.

This change is Reviewable
@SimonSapin
Check that 'style' is compiled in a supported configuration.
Loading status checks…
890257e 
Provide an explanatory error message when the compilation would fail because of missing or duplicate items.
@highfive
Copy link

highfive commented Dec 10, 2017

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Dec 10, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Dec 10, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2017

📌 Commit 890257e has been approved by emilio
@highfive highfive assigned emilio and unassigned jdm Dec 10, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2017

⌛ Testing commit 890257e with merge 29d960e...
bors-servo added a commit that referenced this pull request Dec 10, 2017
@bors-servo
Auto merge of #19540 - servo:style-features, r=emilio
Loading status checks…
29d960e 
Check that 'style' is compiled in a supported configuration.

Provide an explanatory error message when the compilation would fail because of missing or duplicate items.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19540)
<!-- Reviewable:end -->
@emilio
emilio approved these changes Dec 10, 2017
View changes
Copy link
Member

emilio left a comment

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2017

💔 Test failed - mac-rel-wpt4
@jdm
Copy link
Member

jdm commented Dec 10, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 29d960e to master...
@bors-servo bors-servo merged commit 890257e into master Dec 10, 2017
3 of 4 checks passed
3 of 4 checks passed
dependency-ci An error occured
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the style-features branch Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @highfive @emilio @bors-servo @jdm
You can’t perform that action at this time.