Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDowngrade to rustc nightly-2017-11-14 #19574
Merged
+2
−1
Conversation
|
r? @SimonSapin |
|
I’d like to have something in CI to make sure we don’t regress this again. |
|
@SimonSapin yes, I've been talking to @glennw about at least running a smoke test on Mac to check for this. For Linux, we'd need AWS instances with GPUs. |
|
#19575 is the issue for running on CI with GPUs. |
|
Added a minimal smoke test to one of the mac builders. @bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Dec 15, 2017
Downgrade to rustc nightly-2017-11-14 <!-- Please describe your changes on the following line: --> This is causing nightly servo to crash with hardware acceleration. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19519 - [X] These changes do not require tests because testing requires AWS instances with GPUs. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19574) <!-- Reviewable:end -->
|
|
|
Argh, unrelated CI failure? @bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 16, 2017
Downgrade to rustc nightly-2017-11-14 <!-- Please describe your changes on the following line: --> This is causing nightly servo to crash with hardware acceleration. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19519 - [X] These changes do not require tests because testing requires AWS instances with GPUs. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19574) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Dec 17, 2017
Downgrade to rustc nightly-2017-11-14 <!-- Please describe your changes on the following line: --> This is causing nightly servo to crash with hardware acceleration. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19519 - [X] These changes do not require tests because testing requires AWS instances with GPUs. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19574) <!-- Reviewable:end -->
|
|
|
I’ve edited the PR message so that merging this does not close #19519. This is not a fix, only a temporary work-around. We’ll still need to find and file the compiler bug. |
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Dec 18, 2017
Downgrade to rustc nightly-2017-11-14 <!-- Please describe your changes on the following line: --> This is causing nightly servo to crash with hardware acceleration. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes work around #19519 - [X] These changes do not require tests because testing requires AWS instances with GPUs. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19574) <!-- Reviewable:end -->
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Dec 18, 2017
Downgrade to rustc nightly-2017-11-14 <!-- Please describe your changes on the following line: --> This is causing nightly servo to crash with hardware acceleration. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes work around #19519 - [X] These changes do not require tests because testing requires AWS instances with GPUs. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19574) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 18, 2017
Downgrade to rustc nightly-2017-11-14 <!-- Please describe your changes on the following line: --> This is causing nightly servo to crash with hardware acceleration. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes work around #19519 - [X] These changes do not require tests because testing requires AWS instances with GPUs. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19574) <!-- Reviewable:end -->
|
|
|
@bors-servo try- r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 18, 2017
Downgrade to rustc nightly-2017-11-14 <!-- Please describe your changes on the following line: --> This is causing nightly servo to crash with hardware acceleration. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes work around #19519 - [X] These changes do not require tests because testing requires AWS instances with GPUs. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19574) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
|
Downgrading Cargo broke some other things :/ #19635 |
Using |
|
@SimonSapin I believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedDec 15, 2017
•
edited by SimonSapin
This is causing nightly servo to crash with hardware acceleration.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is