Allow deriving Parse on keywords. #19578

emilio · 2017-12-15T19:14:08Z

This makes patches like #19576 much easier.

This change is


        Allow deriving Parse for keywords.

highfive · 2017-12-15T19:14:14Z

Heads up! This PR modifies the following files:

@bholley: components/style/parser.rs, components/style/values/specified/background.rs, components/style/values/specified/position.rs
@canaltinova: components/style/parser.rs, components/style/values/specified/background.rs, components/style/values/specified/position.rs

highfive · 2017-12-15T19:14:15Z

Warning

These commits modify style code, but no tests are modified. Please consider adding a test!


        style: Use derive(Parse) for RepeatKeyword.


        style: Use derive(Parse) for X and Y.

emilio · 2017-12-15T19:15:48Z

r? @Manishearth or @nox

emilio · 2017-12-15T19:15:55Z

(or anyone else)

Manishearth · 2017-12-15T19:29:13Z

✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ 💯💯 💯 💯 💯 💯 💯 💯 💯 💯 ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨

emilio · 2017-12-15T19:58:19Z

✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ 💯💯 💯 💯 💯 💯 💯 💯 💯 💯 ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨

Does this mean r=Manish? :P

Manishearth · 2017-12-15T20:04:46Z

lol no it means I haven't reviewed it yet (doing so)

feel free to land with r=✨ and break all the tools that deal with m-c commits written in Python 2.

Manishearth · 2017-12-15T20:04:54Z

dammit wrong button

emilio · 2017-12-15T20:13:31Z

lol

…

On 12/15/2017 09:05 PM, Manish Goregaokar wrote: dammit wrong button — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19578 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQwuoAat1AO0d0w3W-d2RNXEP2Ji5plks5tAtDsgaJpZM4RD4q_>.

Manishearth

r+

Manishearth · 2017-12-15T20:23:47Z

components/style_derive/lib.rs

@@ -2,6 +2,8 @@
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

+#![recursion_limit = "128"]


emilio · 2017-12-15T20:29:24Z

@bors-servo r=Manishearth

bors-servo · 2017-12-15T20:29:25Z

📌 Commit 8fbdbc8 has been approved by Manishearth

canova · 2017-12-15T20:33:08Z

components/style_derive/cg.rs

+    while let Some(segment) = split_camel_segment(&mut camel_case) {
+        if first {
+            match segment {
+                "Moz" | "Webkit" => first = false,


We should also add "Servo" here.

This is just moving code around, but yeah, you're right.


        style: Handle servo-prefixed stuff correctly.

emilio · 2017-12-15T20:44:08Z

@bors-servo r=Manishearth,canaltinova

bors-servo · 2017-12-15T20:44:09Z

📌 Commit 5b8f651 has been approved by Manishearth,canaltinova

emilio · 2017-12-15T20:44:55Z

@bors-servo p=1

bors-servo · 2017-12-15T20:55:51Z

⌛ Testing commit 5b8f651 with merge e631d16...


        Auto merge of #19578 - emilio:parse-keyword, r=Manishearth,canaltinova

Allow deriving Parse on keywords. This makes patches like #19576 much easier.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19578)

bors-servo · 2017-12-15T21:54:55Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth,canaltinova
Pushing e631d16 to master...

Allow deriving Parse for keywords.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

7036cb0

highfive assigned pcwalton Dec 15, 2017

highfive added the S-awaiting-review label Dec 15, 2017

emilio added 2 commits Dec 15, 2017

style: Use derive(Parse) for RepeatKeyword.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

4abd1dc

style: Use derive(Parse) for X and Y.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

Loading status checks…

8fbdbc8

emilio force-pushed the emilio:parse-keyword branch from 869354a to 8fbdbc8 Dec 15, 2017

highfive assigned Manishearth and unassigned pcwalton Dec 15, 2017

emilio mentioned this pull request Dec 15, 2017

style: Move text-align outside of the mako file. #19576

Merged

2 of 2 tasks complete

Manishearth closed this Dec 15, 2017

Manishearth reopened this Dec 15, 2017

Manishearth approved these changes Dec 15, 2017

View changes

highfive added S-awaiting-merge and removed S-awaiting-review labels Dec 15, 2017

canova reviewed Dec 15, 2017

View changes

style: Handle servo-prefixed stuff correctly.

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

Loading status checks…

5b8f651

highfive added S-awaiting-review and removed S-awaiting-merge labels Dec 15, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Dec 15, 2017

bors-servo merged commit 5b8f651 into servo:master Dec 15, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Dec 15, 2017

bors-servo mentioned this pull request Dec 15, 2017

deny warnings for all crates as default #19573

Closed

3 of 5 tasks complete

emilio mentioned this pull request Feb 22, 2018

Move overflow-y outside of Mako #19183

Closed

servo / servo

Allow deriving Parse on keywords. #19578

Allow deriving Parse on keywords. #19578

emilio commented Dec 15, 2017 •

edited by SimonSapin

highfive commented Dec 15, 2017

highfive commented Dec 15, 2017

emilio commented Dec 15, 2017

emilio commented Dec 15, 2017

Manishearth commented Dec 15, 2017

emilio commented Dec 15, 2017

Manishearth commented Dec 15, 2017

Manishearth commented Dec 15, 2017

emilio commented Dec 15, 2017

Manishearth left a comment

This comment has been minimized.

emilio commented Dec 15, 2017

bors-servo commented Dec 15, 2017

This comment has been minimized.

This comment has been minimized.

emilio commented Dec 15, 2017

bors-servo commented Dec 15, 2017

emilio commented Dec 15, 2017

bors-servo commented Dec 15, 2017

bors-servo commented Dec 15, 2017

servo / servo

Join GitHub today

Allow deriving Parse on keywords. #19578

Allow deriving Parse on keywords. #19578

Conversation

emilio commented Dec 15, 2017 • edited by SimonSapin

highfive commented Dec 15, 2017

highfive commented Dec 15, 2017

emilio commented Dec 15, 2017

emilio commented Dec 15, 2017

Manishearth commented Dec 15, 2017

emilio commented Dec 15, 2017

Manishearth commented Dec 15, 2017

Manishearth commented Dec 15, 2017

emilio commented Dec 15, 2017

Manishearth left a comment

This comment has been minimized.

Manishearth Dec 15, 2017

emilio commented Dec 15, 2017

bors-servo commented Dec 15, 2017

This comment has been minimized.

canova Dec 15, 2017

This comment has been minimized.

emilio Dec 15, 2017

emilio commented Dec 15, 2017

bors-servo commented Dec 15, 2017

emilio commented Dec 15, 2017

bors-servo commented Dec 15, 2017

bors-servo commented Dec 15, 2017

emilio commented Dec 15, 2017 •

edited by SimonSapin