Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to Web Animations spec #19580

Merged
merged 1 commit into from Dec 16, 2017
Merged

Update references to Web Animations spec #19580

merged 1 commit into from Dec 16, 2017

Conversation

@birtles
Copy link
Contributor

birtles commented Dec 15, 2017 •
edited by SimonSapin

This has been reviewed in Gecko bug 1425548.

This change is Reviewable
@birtles
Update references to Web Animations spec
Loading status checks…
150db42
@highfive
Copy link

highfive commented Dec 15, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/animated/mod.rs, components/style/properties/helpers/animated_properties.mako.rs
  • @canaltinova: components/style/values/animated/mod.rs, components/style/properties/helpers/animated_properties.mako.rs
  • @emilio: components/style/values/animated/mod.rs, components/style/properties/helpers/animated_properties.mako.rs
@highfive
Copy link

highfive commented Dec 15, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Dec 15, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 15, 2017

📌 Commit 150db42 has been approved by emilio
@birtles
Copy link
Contributor Author

birtles commented Dec 15, 2017

@bors-servo r=hiro
@bors-servo
Copy link
Contributor

bors-servo commented Dec 15, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #19568
@bors-servo
Copy link
Contributor

bors-servo commented Dec 15, 2017

📌 Commit 150db42 has been approved by hiro
@highfive highfive assigned emilio and unassigned metajack Dec 15, 2017
@birtles
Copy link
Contributor Author

birtles commented Dec 15, 2017

Oops, didn't see emilio's r+. You're too fast!
@bors-servo
Copy link
Contributor

bors-servo commented Dec 15, 2017

⌛ Testing commit 150db42 with merge f7440bf...
bors-servo added a commit that referenced this pull request Dec 15, 2017
@bors-servo
Auto merge of #19580 - birtles:update-web-animations-link, r=hiro
Loading status checks…
f7440bf 
Update references to Web Animations spec

This has been reviewed in [Gecko bug 1425548](https://bugzilla.mozilla.org/show_bug.cgi?id=1425548).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19580)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: hiro
Pushing f7440bf to master...
@bors-servo bors-servo merged commit 150db42 into servo:master Dec 16, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@birtles @highfive @emilio @bors-servo @metajack
You can’t perform that action at this time.