Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use [patch] instead of [replace] #19590

Merged
merged 1 commit into from Dec 17, 2017
Merged

Use [patch] instead of [replace] #19590

merged 1 commit into from Dec 17, 2017

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Dec 17, 2017

CC servo/webrender#2215

Also, [replace] prevented using [patch] for other crates. (Cargo forbids using both.)


This change is Reviewable

CC servo/webrender#2215

Also, `[replace]` prevented using `[patch]` for other crates.
(Cargo forbids using both.)
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 17, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2017

📌 Commit 9eee610 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2017

Testing commit 9eee610 with merge 3a37d80...

bors-servo added a commit that referenced this pull request Dec 17, 2017
Use [patch] instead of [replace]

CC servo/webrender#2215

Also, `[replace]` prevented using `[patch]` for other crates. (Cargo forbids using both.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19590)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2017

@bors-servo bors-servo merged commit 9eee610 into master Dec 17, 2017
3 of 4 checks passed
3 of 4 checks passed
dependency-ci An error occured
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the patch branch Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.