Skip to content

Comments

Actually run Taskcluster jobs on PRs#19591

Merged
bors-servo merged 2 commits intoservo:masterfrom
aneeshusa:actually-trigger-taskcluster
Jan 5, 2018
Merged

Actually run Taskcluster jobs on PRs#19591
bors-servo merged 2 commits intoservo:masterfrom
aneeshusa:actually-trigger-taskcluster

Conversation

@aneeshusa
Copy link
Contributor

@aneeshusa aneeshusa commented Dec 17, 2017

Spawn TC jobs on the following events:

  • Pull request opened or reopened
  • New commit made in pull request

Spawn TC jobs for pull requests started by anybody,
not just trusted collaborators.
This is safe for now as we do not provide any scopes to spawned jobs.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

Spawn TC jobs on the following events:
  - Pull request opened or reopened
  - New commit made in pull request

Spawn TC jobs for pull requests started by anybody,
not just trusted collaborators.
This is safe for now as we do not provide any scopes to spawned jobs.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 17, 2017
@aneeshusa
Copy link
Contributor Author

I wasn't able to find any TC jobs being spawned (based on instructions I got from @imbstack in the airport, so maybe I'm not looking in the right place). Looking at the TC quickstart tool, however, it looks like we need to tell TC when to trigger jobs.

r? @edunham

@highfive highfive assigned edunham and unassigned mbrubeck Dec 17, 2017
@aneeshusa
Copy link
Contributor Author

And it looks like there's a new Taskcluster status check on this PR whereas I don't see any on other PRs, so this seems to be needed.

We have not yet pushed a :latest tag,
so use the (old) named tag that we have for now.
@edunham
Copy link
Contributor

edunham commented Jan 4, 2018

Test failed due to missing pulseaudio stuff in the container -- final lines of https://public-artifacts.taskcluster.net/fIPVrPBAR1CizSLj4EvVFw/0/public/logs/live_backing.log -- but since we're ignoring the TC results at this time I'd prefer to land this now then debug the container while we watch it run on Servo's regular activity. I'll email the list explaining the new check and that it's ok to ignore for now.

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 6446aff has been approved by edunham

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 4, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 6446aff with merge 6440f17...

bors-servo pushed a commit that referenced this pull request Jan 5, 2018
Actually run Taskcluster jobs on PRs

Spawn TC jobs on the following events:
  - Pull request opened or reopened
  - New commit made in pull request

Spawn TC jobs for pull requests started by anybody,
not just trusted collaborators.
This is safe for now as we do not provide any scopes to spawned jobs.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19591)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: edunham
Pushing 6440f17 to master...

@bors-servo bors-servo merged commit 6446aff into servo:master Jan 5, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 5, 2018
@aneeshusa
Copy link
Contributor Author

@edunham thanks for reviewing and sending out an email - that's a great idea that didn't even occur to me!

bors-servo pushed a commit to servo/saltfs that referenced this pull request May 15, 2018
Add taskcluster yml

We need newer Docker images to be able to use TC for servo (see servo/servo#19591). Use TC to build these images from the saltfs repository.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/768)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants