Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upActually run Taskcluster jobs on PRs #19591
Conversation
Spawn TC jobs on the following events: - Pull request opened or reopened - New commit made in pull request Spawn TC jobs for pull requests started by anybody, not just trusted collaborators. This is safe for now as we do not provide any scopes to spawned jobs.
|
I wasn't able to find any TC jobs being spawned (based on instructions I got from @imbstack in the airport, so maybe I'm not looking in the right place). Looking at the TC quickstart tool, however, it looks like we need to tell TC when to trigger jobs. r? @edunham |
|
And it looks like there's a new Taskcluster status check on this PR whereas I don't see any on other PRs, so this seems to be needed. |
We have not yet pushed a :latest tag, so use the (old) named tag that we have for now.
|
Test failed due to missing pulseaudio stuff in the container -- final lines of https://public-artifacts.taskcluster.net/fIPVrPBAR1CizSLj4EvVFw/0/public/logs/live_backing.log -- but since we're ignoring the TC results at this time I'd prefer to land this now then debug the container while we watch it run on Servo's regular activity. I'll email the list explaining the new check and that it's ok to ignore for now. @bors-servo r+ |
|
|
Actually run Taskcluster jobs on PRs Spawn TC jobs on the following events: - Pull request opened or reopened - New commit made in pull request Spawn TC jobs for pull requests started by anybody, not just trusted collaborators. This is safe for now as we do not provide any scopes to spawned jobs. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19591) <!-- Reviewable:end -->
|
|
|
@edunham thanks for reviewing and sending out an email - that's a great idea that didn't even occur to me! |
Add taskcluster yml We need newer Docker images to be able to use TC for servo (see servo/servo#19591). Use TC to build these images from the saltfs repository. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/768) <!-- Reviewable:end -->
aneeshusa commentedDec 17, 2017
•
edited by SimonSapin
Spawn TC jobs on the following events:
Spawn TC jobs for pull requests started by anybody,
not just trusted collaborators.
This is safe for now as we do not provide any scopes to spawned jobs.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is