Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add a FIXME comment that I need to write a test-case for. #19595

Merged
merged 1 commit into from Dec 18, 2017

Conversation

@emilio
Copy link
Member

emilio commented Dec 18, 2017

This change is Reviewable

@highfive
Copy link

highfive commented Dec 18, 2017

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Dec 18, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Dec 18, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2017

📌 Commit 0e78138 has been approved by emilio

@highfive highfive assigned emilio and unassigned KiChjang Dec 18, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2017

Testing commit 0e78138 with merge fab8042...

bors-servo added a commit that referenced this pull request Dec 18, 2017
style: Add a FIXME comment that I need to write a test-case for.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19595)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2017

💔 Test failed - linux-rel-wpt

@CYBAI
Copy link
Collaborator

CYBAI commented Dec 18, 2017

Intermittent with

{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/css/css-backgrounds/box-shadow-syntax-001.xht", "line": 28470, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_mozilla/css/border_radius_elliptical_a.html", "line": 40711, "action": "test_result", "expected": "FAIL"}
@jdm
Copy link
Member

jdm commented Dec 18, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2017

@bors-servo bors-servo merged commit 0e78138 into servo:master Dec 18, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.