Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert canvas IPC changes #19599

Merged
merged 1 commit into from Dec 18, 2017
Merged

Revert canvas IPC changes #19599

merged 1 commit into from Dec 18, 2017
+18 −13

Conversation

@jdm
Copy link
Member

jdm commented Dec 18, 2017 •
edited

#19547 is responsible for the surge of new intermittent timeouts in canvas-related tests. There's nothing wrong with the change, so I suspect an underlying problem in ipc-channel instead.

Fixes #19592. Fixes #19593. Fixes #19594. Fixes #19597.

This change is Reviewable
@jdm
Revert "Send IPC receiver for canvas as part of CreateCanvasPaintThre…
Loading status checks…
0e211d0 
…ad message"

This reverts commit a504c93.
@highfive
Copy link

highfive commented Dec 18, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs, components/script/dom/canvasrenderingcontext2d.rs
  • @cbrewster: components/constellation/constellation.rs
  • @paulrouget: components/constellation/constellation.rs
  • @fitzgen: components/script_traits/script_msg.rs, components/script/dom/canvasrenderingcontext2d.rs
  • @KiChjang: components/script_traits/script_msg.rs, components/script/dom/canvasrenderingcontext2d.rs
@highfive
Copy link

highfive commented Dec 18, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Dec 18, 2017

@bors-servo: p=1
@jdm jdm mentioned this pull request Dec 18, 2017
Open
@asajeffrey
Copy link
Member

asajeffrey commented Dec 18, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2017

📌 Commit 0e211d0 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned nox Dec 18, 2017
@tigercosmos
Copy link
Collaborator

tigercosmos commented Dec 18, 2017

@jdm you miss fix #19593.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2017

⌛ Testing commit 0e211d0 with merge 37fe9f2...
bors-servo added a commit that referenced this pull request Dec 18, 2017
@bors-servo
Auto merge of #19599 - jdm:revertcanvas, r=asajeffrey
Loading status checks…
37fe9f2 
Revert canvas IPC changes

#19547 is responsible for the surge of new intermittent timeouts in canvas-related tests. There's nothing wrong with the change, so I suspect an underlying problem in ipc-channel instead.

Fixes #19592. #19593. Fixes #19594. Fixes #19597.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19599)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Dec 18, 2017
Merged
3 of 5 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: asajeffrey
Pushing 37fe9f2 to master...
@bors-servo bors-servo merged commit 0e211d0 into servo:master Dec 18, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @asajeffrey @bors-servo @tigercosmos @nox
You can’t perform that action at this time.