Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashglobe: Dump the requested aligment if out of memory while allocating a table #19607

Merged

Conversation

@BorisChiou
Copy link
Contributor

commented Dec 19, 2017

This is for Bug 1418806 and Bug 1416903. We need not only the requested size
but also the requested alignment for debugging.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable

@BorisChiou BorisChiou changed the title hashglobe: Dump the requested aligment if out of memory while allocating a table. hashglobe: Dump the requested aligment if out of memory while allocating a table Dec 19, 2017
@BorisChiou

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2017

⌛️ Trying commit 8a68d33 with merge af13987...

bors-servo added a commit that referenced this pull request Dec 19, 2017
…, r=<try>

hashglobe: Dump the requested aligment if out of memory while allocating a table

This is for Bug 1418806 and Bug 1416903. We need not only the requested size
but also the request alignment for debugging.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19607)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2017

💔 Test failed - linux-rel-css

@BorisChiou BorisChiou force-pushed the BorisChiou:stylo/crash/out_of_memory_alignment branch from 8a68d33 to 4990c26 Dec 19, 2017
@BorisChiou

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2017

⌛️ Trying commit 4990c26 with merge 53b3098...

bors-servo added a commit that referenced this pull request Dec 19, 2017
…, r=<try>

hashglobe: Dump the requested aligment if out of memory while allocating a table

This is for Bug 1418806 and Bug 1416903. We need not only the requested size
but also the request alignment for debugging.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19607)
<!-- Reviewable:end -->
@BorisChiou

This comment has been minimized.

@BorisChiou

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

r? @emilio

@highfive highfive assigned emilio and unassigned wafflespeanut Dec 19, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2017

💔 Test failed - mac-rel-wpt1

@emilio
emilio approved these changes Dec 20, 2017
match self.allocation_size {
Some(size) => write!(f, "{}, allocation size: {}", self.reason, size),
match self.allocation_info {
Some(ref info) => write!(f, "{}, allocation size: {}, alignment: {}",

This comment has been minimized.

Copy link
@emilio

emilio Dec 20, 2017

Member

let's use braces here, otherwise the alignment looks pretty weird.

@BorisChiou BorisChiou force-pushed the BorisChiou:stylo/crash/out_of_memory_alignment branch from 4990c26 to aebe2cf Jan 2, 2018
@highfive highfive removed the S-tests-failed label Jan 2, 2018
@BorisChiou

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2018

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

📌 Commit aebe2cf has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

⌛️ Testing commit aebe2cf with merge 27a443f...

bors-servo added a commit that referenced this pull request Jan 2, 2018
…, r=emilio

hashglobe: Dump the requested aligment if out of memory while allocating a table

This is for Bug 1418806 and Bug 1416903. We need not only the requested size
but also the requested alignment for debugging.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19607)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

💔 Test failed - linux-rel-css

@BorisChiou

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

💔 Test failed - linux-rel-css

@emilio

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

💔 Test failed - linux-rel-css

@emilio

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

@bors-servo bors-servo merged commit aebe2cf into servo:master Jan 2, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.