Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Don't support a list of selectors in ::slotted yet. #19610

Merged
merged 1 commit into from Dec 20, 2017
Merged

style: Don't support a list of selectors in ::slotted yet. #19610

merged 1 commit into from Dec 20, 2017
+62 −35

Conversation

@emilio
Copy link
Member

emilio commented Dec 20, 2017 •
edited by SimonSapin

Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh

This change is Reviewable
@emilio
style: Don't support a list of selectors in ::slotted yet.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
b556ddb 
Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh
@highfive
Copy link

highfive commented Dec 20, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/selector_map.rs, components/selectors/matching.rs, components/selectors/parser.rs
  • @canaltinova: components/style/selector_map.rs
@highfive
Copy link

highfive commented Dec 20, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Dec 20, 2017

@bors-servo r=xidorn
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

📌 Commit b556ddb has been approved by xidorn
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

⌛ Testing commit b556ddb with merge f12b6a3...
bors-servo added a commit that referenced this pull request Dec 20, 2017
@bors-servo
Auto merge of #19610 - emilio:slotted-list, r=xidorn
Loading status checks…
f12b6a3 
style: Don't support a list of selectors in ::slotted yet.

Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented Dec 20, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented Dec 20, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

⌛ Testing commit b556ddb with merge e074a1c...
bors-servo added a commit that referenced this pull request Dec 20, 2017
@bors-servo
Auto merge of #19610 - emilio:slotted-list, r=xidorn
Loading status checks…
e074a1c 
style: Don't support a list of selectors in ::slotted yet.

Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19610)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: xidorn
Pushing e074a1c to master...
@bors-servo bors-servo merged commit b556ddb into servo:master Dec 20, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm
Copy link
Member

jdm commented Dec 20, 2017

Valgrind failures on mozilla-central: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=f58dca05f26f69116bf5a736d384e97963beec61&selectedJob=152699403&filter-searchStr=71c65f839aa0a31806ffba7d7a50d5642e7c7c45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @jdm @nox
You can’t perform that action at this time.