Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Don't support a list of selectors in ::slotted yet. #19610

Merged
merged 1 commit into from Dec 20, 2017

Conversation

@emilio
Copy link
Member

emilio commented Dec 20, 2017

Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh


This change is Reviewable

Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh
@highfive
Copy link

highfive commented Dec 20, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/selector_map.rs, components/selectors/matching.rs, components/selectors/parser.rs
  • @canaltinova: components/style/selector_map.rs
@highfive
Copy link

highfive commented Dec 20, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Dec 20, 2017

@bors-servo r=xidorn

@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

📌 Commit b556ddb has been approved by xidorn

@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

Testing commit b556ddb with merge f12b6a3...

bors-servo added a commit that referenced this pull request Dec 20, 2017
style: Don't support a list of selectors in ::slotted yet.

Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

💔 Test failed - mac-rel-css1

@jdm
Copy link
Member

jdm commented Dec 20, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

💔 Test failed - mac-rel-css1

@jdm
Copy link
Member

jdm commented Dec 20, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

Testing commit b556ddb with merge e074a1c...

bors-servo added a commit that referenced this pull request Dec 20, 2017
style: Don't support a list of selectors in ::slotted yet.

Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19610)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

@bors-servo bors-servo merged commit b556ddb into servo:master Dec 20, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.