Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updeny warnings #19612
Merged
deny warnings #19612
+22
−19
Conversation
highfive
commented
Dec 20, 2017
|
Heads up! This PR modifies the following files:
|
|
r? @jdm This looks reasonable to me. |
|
@bors-servo r+ |
|
|
|
@bors-servo r- Please also remove |
|
Thanks for your work on this! |
|
r? @SimonSapin |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 20, 2017
deny warnings <!-- Please describe your changes on the following line: --> deny warnings related to #19573 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #19572 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19612) <!-- Reviewable:end -->
|
|
|
It's weird. it should be but it becomes |
|
If you use |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Dec 21, 2017
deny warnings <!-- Please describe your changes on the following line: --> deny warnings related to #19573 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #19572 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19612) <!-- Reviewable:end -->
This indicates that |
|
@SimonSapin You are right! |
|
When we change RUSTFLAGS between building and compiling unit tests, we have to recompile everything. This makes TravisCI time out, and will make all of our builds take longer. |
|
@jdm Ok I will fix it. |
|
now it it OK |
components/style/lib.rs
Outdated
| @@ -23,7 +23,6 @@ | |||
| //! [cssparser]: ../cssparser/index.html | |||
| //! [selectors]: ../selectors/index.html | |||
|
|
|||
| #![deny(warnings)] | |||
This comment has been minimized.
This comment has been minimized.
jdm
Dec 21, 2017
Member
Let's leave these explicit instances of denying warnings, since developers have grown used to developing with them present.
This comment has been minimized.
This comment has been minimized.
SimonSapin
Dec 21, 2017
Member
@jdm Shouldn’t we rather be consistent between crates? As far as I’m concerned it’s an historical accident that some crates have it and not others, not something useful.
This comment has been minimized.
This comment has been minimized.
emilio
Dec 21, 2017
Member
I don't personally care, but at least nsstring is vendored code, so I'd rather leave it in that crate at least.
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 21, 2017
deny warnings <!-- Please describe your changes on the following line: --> deny warnings related to #19573 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #19572 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19612) <!-- Reviewable:end -->
|
|
SimonSapin
added a commit
that referenced
this pull request
Jan 31, 2018
We already have #19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings: https://bugzilla.mozilla.org/show_bug.cgi?id=1434619
bors-servo
added a commit
that referenced
this pull request
Jan 31, 2018
Remove #![deny(warnings)] We already have #19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings: https://bugzilla.mozilla.org/show_bug.cgi?id=1434619 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19914) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 31, 2018
…); r=nox We already have servo/servo#19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings: https://bugzilla.mozilla.org/show_bug.cgi?id=1434619 Source-Repo: https://github.com/servo/servo Source-Revision: 7546c37f1e921a112fef5828c59c6738a98c3f30 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : ed5c34f72e321ce0051347bd5156389d1ef26bef
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 5, 2018
We already have servo/servo#19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings: Source-Repo: https://github.com/servo/servo Source-Revision: 7546c37f1e921a112fef5828c59c6738a98c3f30 --HG-- extra : source : bbef24920c2bd12a23b63a100d83e6d240ea74dc extra : amend_source : dc20fe3c006be58542d64afc137ac0a84f74508d
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Feb 11, 2018
We already have servo/servo#19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings: Source-Repo: https://github.com/servo/servo Source-Revision: 7546c37f1e921a112fef5828c59c6738a98c3f30
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
…); r=nox We already have servo/servo#19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings: https://bugzilla.mozilla.org/show_bug.cgi?id=1434619 Source-Repo: https://github.com/servo/servo Source-Revision: 7546c37f1e921a112fef5828c59c6738a98c3f30 UltraBlame original commit: bbef24920c2bd12a23b63a100d83e6d240ea74dc
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…); r=nox We already have servo/servo#19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings: https://bugzilla.mozilla.org/show_bug.cgi?id=1434619 Source-Repo: https://github.com/servo/servo Source-Revision: 7546c37f1e921a112fef5828c59c6738a98c3f30 UltraBlame original commit: bbef24920c2bd12a23b63a100d83e6d240ea74dc
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
…); r=nox We already have servo/servo#19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings: https://bugzilla.mozilla.org/show_bug.cgi?id=1434619 Source-Repo: https://github.com/servo/servo Source-Revision: 7546c37f1e921a112fef5828c59c6738a98c3f30 UltraBlame original commit: bbef24920c2bd12a23b63a100d83e6d240ea74dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tigercosmos commentedDec 20, 2017
•
edited by SimonSapin
deny warnings
related to #19573
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is