Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert NS_STYLE_BORDER_IMAGE_REPEAT_* to an enum class #19618

Merged
merged 1 commit into from Dec 21, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Convert NS_STYLE_BORDER_IMAGE_REPEAT_* to an enum class.

  • Loading branch information
upsuper committed Dec 21, 2017
commit 11bd1bc38c5287509b31b3b5cab18d56e2c4df7d

Large diffs are not rendered by default.

@@ -1789,16 +1789,14 @@ fn static_assert() {

pub fn set_border_image_repeat(&mut self, v: longhands::border_image_repeat::computed_value::T) {
use properties::longhands::border_image_repeat::computed_value::RepeatKeyword;
use gecko_bindings::structs;
use gecko_bindings::structs::StyleBorderImageRepeat;

% for i, side in enumerate(["H", "V"]):
let k = match v.${i} {
self.gecko.mBorderImageRepeat${side} = match v.${i} {
% for keyword in border_image_repeat_keywords:
RepeatKeyword::${keyword} => structs::NS_STYLE_BORDER_IMAGE_REPEAT_${keyword.upper()},
RepeatKeyword::${keyword} => StyleBorderImageRepeat::${keyword},
% endfor
};

self.gecko.mBorderImageRepeat${side} = k as u8;
% endfor
}

@@ -1813,14 +1811,13 @@ fn static_assert() {

pub fn clone_border_image_repeat(&self) -> longhands::border_image_repeat::computed_value::T {
use properties::longhands::border_image_repeat::computed_value::RepeatKeyword;
use gecko_bindings::structs;
use gecko_bindings::structs::StyleBorderImageRepeat;

% for side in ["H", "V"]:
let servo_${side.lower()} = match self.gecko.mBorderImageRepeat${side} as u32 {
let servo_${side.lower()} = match self.gecko.mBorderImageRepeat${side} {
% for keyword in border_image_repeat_keywords:
structs::NS_STYLE_BORDER_IMAGE_REPEAT_${keyword.upper()} => RepeatKeyword::${keyword},
StyleBorderImageRepeat::${keyword} => RepeatKeyword::${keyword},
% endfor
x => panic!("Found unexpected value in mBorderImageRepeat${side}: {:?}", x),
};
% endfor
longhands::border_image_repeat::computed_value::T(servo_h, servo_v)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.