Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint worklets: Add pref for blocking sleep to be enabled for wpt tests #19630

Merged
merged 1 commit into from Dec 22, 2017

Commits on Dec 22, 2017

  1. Paint worklets: Add pref for blocking sleep to be enabled for wpt tests

    In aa48a2c I added a timeout for paint
    worklet threads. However, the test was broken. The blocking sleep
    function that was implemented as part of that commit was guarded behind
    the `dom.worklet.blockingsleep.enabled` pref, and while I ran the
    wpt-tests with that pref enabled, the test runner for sure did not.
    I tried running the test _without_ the pref enabled, and the tests still
    pass. This is because even the reference in that reftest is that of
    a broken image background, and *both* the paintworklet thread timing out
    and `sleep()` not being in scope would render the same thing: a broken
    image, which compares equal to the reference.
    
    This patch makes sure that now the pref is enabled for wpt worklet
    tests, and that such we can distinguish an actual timeout (test pass)
    from an unexpected situation (when we should fail the test).
    yati-sagade committed Dec 22, 2017
You can’t perform that action at this time.