Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Some trivial cleanup. #19641

Merged
merged 1 commit into from Dec 25, 2017
Merged

style: Some trivial cleanup. #19641

merged 1 commit into from Dec 25, 2017

Conversation

@emilio
Copy link
Member

emilio commented Dec 24, 2017 •
edited by SimonSapin

This change is Reviewable
@emilio
style: Some trivial cleanup.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
a491cca
@highfive
Copy link

highfive commented Dec 24, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/counter_style/mod.rs, components/style/stylesheets/document_rule.rs, components/style/values/mod.rs
  • @canaltinova: components/style/counter_style/mod.rs, components/style/stylesheets/document_rule.rs, components/style/values/mod.rs
@highfive
Copy link

highfive commented Dec 24, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Dec 24, 2017

r? @CYBAI

Hi @CYBAI, wanna review this one? :)

@bors-servo delegate=cybai
@bors-servo
Copy link
Contributor

bors-servo commented Dec 24, 2017

✌️ @CYBAI can now approve this pull request
@CYBAI
CYBAI approved these changes Dec 25, 2017
View changes
Copy link
Collaborator

CYBAI left a comment

The changes looks great to me!
Thanks for giving me the chance to be a reviewer 😄
@CYBAI
Copy link
Collaborator

CYBAI commented Dec 25, 2017

@bors-servo r=cybai
@bors-servo
Copy link
Contributor

bors-servo commented Dec 25, 2017

📌 Commit a491cca has been approved by cybai
@bors-servo
Copy link
Contributor

bors-servo commented Dec 25, 2017

⌛ Testing commit a491cca with merge d96fb89...
bors-servo added a commit that referenced this pull request Dec 25, 2017
@bors-servo
Auto merge of #19641 - emilio:christmas-cleanup, r=cybai
Loading status checks…
d96fb89 
style: Some trivial cleanup.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19641)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 25, 2017

💔 Test failed - mac-dev-unit
@CYBAI
Copy link
Collaborator

CYBAI commented Dec 25, 2017

@bors-servo retry #19495
@bors-servo
Copy link
Contributor

bors-servo commented Dec 25, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 25, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: cybai
Pushing d96fb89 to master...
@bors-servo bors-servo merged commit a491cca into servo:master Dec 25, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:christmas-cleanup branch Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CYBAI CYBAI

Assignees

@mbrubeck mbrubeck

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @CYBAI @mbrubeck
You can’t perform that action at this time.