Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Simplify ::-moz-fieldset-content special-casing. #19661
Merged
Conversation
The style adjuster knows about the pseudo, so there's no reason to thread that info down. There are more simplifications that can be done in followups, cleaning a bit the cascade flags too, those will come later.
highfive
commented
Dec 30, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Dec 30, 2017
|
|
|
r? @upsuper |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 30, 2017
style: Simplify ::-moz-fieldset-content special-casing. The style adjuster knows about the pseudo, so there's no reason to thread that info down. There are more simplifications that can be done in followups, cleaning a bit the cascade flags too, those will come later. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19661) <!-- Reviewable:end -->
|
(Isn't it supposed to still be in holiday...?) |
emilio
added a commit
to emilio/servo
that referenced
this pull request
Dec 30, 2017
On top of servo#19661. The NAC condition is pointless because NAC don't match author rules unless they are a pseudo-element too.
|
|
|
@bors-servo retry |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 31, 2017
…psuper style: Simplify "prohibit display: contents" adjustment. On top of #19661. The NAC condition is pointless because NAC don't match author rules unless they are a pseudo-element too. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19662) <!-- Reviewable:end -->
emilio
added a commit
to emilio/servo
that referenced
this pull request
Dec 31, 2017
On top of servo#19661. The NAC condition is pointless because NAC don't match author rules unless they are a pseudo-element too.
bors-servo
added a commit
that referenced
this pull request
Dec 31, 2017
…psuper style: Simplify "prohibit display: contents" adjustment. On top of #19661. The NAC condition is pointless because NAC don't match author rules unless they are a pseudo-element too. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19662) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedDec 30, 2017
•
edited by SimonSapin
The style adjuster knows about the pseudo, so there's no reason to thread that
info down.
There are more simplifications that can be done in followups, cleaning a bit the
cascade flags too, those will come later.
This change is