Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.24.0-nightly (0a3761e63 2018-01-03) #19683

Merged
merged 6 commits into from Jan 10, 2018

We use Nigthly Cargo with Stable Rust

Nightly now has incremental compilation as a stable feature,
but that’s not in the stable channel yet.
  • Loading branch information
SimonSapin committed Jan 10, 2018
commit c8f542afacce91a71e7805f7b610d5ec66195b8d
@@ -297,9 +297,8 @@ def resolverelative(category, key):
def set_use_geckolib_toolchain(self, use_geckolib_toolchain=True):
self._use_geckolib_toolchain = use_geckolib_toolchain
if use_geckolib_toolchain:
# Cargo maintainer's position is that CARGO_INCREMENTAL is a nightly-only feature
# and should not be used on the stable channel.
# https://github.com/rust-lang/cargo/issues/3835
# We use Cargo Nightly 1.24 with Rust 1.22,
# it passes `-C incremental` to rustc, which is new in Rust 1.24.
self.config["build"]["incremental"] = False

def toolchain(self):
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.