Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile to build container used by TaskCluster #19694

Closed
wants to merge 1 commit into from

Conversation

@edunham
Copy link
Contributor

edunham commented Jan 4, 2018

TC pulls the container from https://hub.docker.com/r/servobrowser/servo-linux-dev/

Perms to upload there are managed with other infra secrets

This is as the Dockerfile stood when I last uploaded; future work includes
automating the build and push upon Dockerfile changes landing in this repo.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes address the issue that edunham is embarrassed to send a "we're changing a thing" email without the "and you can change it too" step, which requires the Dockerfile that generated the container that TaskCluster pulls from to live in a sensible public place
  • There are tests for these changes OR
  • These changes do not require tests because _____
  • these changes are prerequisite to adding more better tests

r? @aneeshusa


This change is Reviewable

TC pulls the container from  https://hub.docker.com/r/servobrowser/servo-linux-dev/
Perms to upload there are managed with other infra secrets
This is as the Dockerfile stood when I last uploaded; future work includes
automating the build and push upon Dockerfile changes landing in this repo.
@highfive
Copy link

highfive commented Jan 4, 2018

Heads up! This PR modifies the following files:

@aneeshusa
Copy link
Member

aneeshusa commented Jan 8, 2018

@edunham Instead of manually listing out the (os-specific) instructions in the Dockerfile (apt-get, pip install), I would prefer to leverage our existing investment in Salt for defining build requirements.
How do you feel about servo/saltfs#768 instead?
Having this live in saltfs for now also means we can auto-build the Dockerfile on each saltfs change via TaskCluster, instead of having to come and manually update this Dockerfile later for any changes.

@aneeshusa
Copy link
Member

aneeshusa commented Jan 27, 2018

@edunham @metajack @larsbergstrom could you please chime in on this or the other PR? It sounds like the Webrender folks are having a really great experience with TC so far, so I'd love to make progress on the Servo side!

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 10, 2018

@edunham ping :-)

@edunham
Copy link
Contributor Author

edunham commented May 15, 2018

This is currently wrong because we switched to using rustup on every build anyways...

@aneeshusa
Copy link
Member

aneeshusa commented May 21, 2018

Closing as servo/saltfs#768 has been merged.

@aneeshusa aneeshusa closed this May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.