Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why aren't these tests run? #19700

Closed
wants to merge 1 commit into from
Closed

Why aren't these tests run? #19700

wants to merge 1 commit into from

Conversation

@pyfisch
Copy link
Contributor

pyfisch commented Jan 5, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@pyfisch
Why aren't these tests run?
Loading status checks…
706033c
@pyfisch
Copy link
Contributor Author

pyfisch commented Jan 5, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2018

⌛ Trying commit 706033c with merge 48c7105...
bors-servo added a commit that referenced this pull request Jan 5, 2018
@bors-servo
Auto merge of #19700 - pyfisch:why-tests, r=<try>
Loading status checks…
48c7105 
Why aren't these tests run?

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2018

💔 Test failed - mac-dev-unit
@CYBAI
Copy link
Collaborator

CYBAI commented Jan 5, 2018

Failed with #19495
@emilio
Copy link
Member

emilio commented Jan 5, 2018

cc @jdm
@jdm
Copy link
Member

jdm commented Jan 5, 2018

@bors-servo: r+
The try build reports success. That's mysterious.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2018

📌 Commit 706033c has been approved by jdm
@highfive highfive assigned jdm and unassigned metajack Jan 5, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2018

⌛ Testing commit 706033c with merge e56770e...
bors-servo added a commit that referenced this pull request Jan 5, 2018
@bors-servo
Auto merge of #19700 - pyfisch:why-tests, r=jdm
Loading status checks…
e56770e 
Why aren't these tests run?

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19700)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2018

💔 Test failed - mac-dev-unit
@pyfisch
Copy link
Contributor Author

pyfisch commented Jan 5, 2018

@jdm Do you have an idea why these tests marked as "FAIL" in the .ini files are never run? Neither on my machine nor on the builder?

I skimmed over the folder contents and noticed these tests where marked as failing but could not find a reason why they should be and removed the files. But they are not executed even if I try only to run a single test.
@jdm
Copy link
Member

jdm commented Jan 5, 2018

It looks like it might be because border-bottom-left-radius-003.xht uses border-bottom-left-radius-004.xht as a reference, and border-bottom-left-radius-004.xht uses border-bottom-left-radius-003.xht as a radius, and I think the manifest just becomes confused?
@jdm
Copy link
Member

jdm commented Jan 5, 2018

I am writing a lint for web-platform-tests that detects these cases and forbids them. We'll start running these tests once that PR is merged upstream and we sync Servo's copy.
@jdm jdm closed this Jan 5, 2018
@pyfisch pyfisch deleted the pyfisch:why-tests branch May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@pyfisch @bors-servo @CYBAI @emilio @jdm @metajack @highfive
You can’t perform that action at this time.