Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upclean todo #19714
Closed
clean todo #19714
Conversation
highfive
commented
Jan 7, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jan 7, 2018
|
|
|
It looks like this isn't actually done yet, I don't remember why I closed that original issue... |
|
Either way, this issue cannot be fixed yet until we upgrade our hyper to version 0.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tigercosmos commentedJan 7, 2018
•
edited by SimonSapin
part of #19685
#15569 was done (confirm by @KiChjang )
r? @KiChjang
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is