Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (inset box shadow fix, line decoration optimizations) #19725

Merged
merged 1 commit into from Jan 9, 2018
Merged

Update WR (inset box shadow fix, line decoration optimizations) #19725

merged 1 commit into from Jan 9, 2018

Conversation

@glennw
Copy link
Member

glennw commented Jan 9, 2018 •
edited by SimonSapin

This change is Reviewable
@gw3583
Update WR (inset box shadow fix, line decoration optimizations)
Loading status checks…
acf1244
@mbrubeck
Copy link
Contributor

mbrubeck commented Jan 9, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

📌 Commit acf1244 has been approved by mbrubeck
@highfive highfive assigned mbrubeck and unassigned emilio Jan 9, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

⌛ Testing commit acf1244 with merge d9a12a7...
bors-servo added a commit that referenced this pull request Jan 9, 2018
@bors-servo
Auto merge of #19725 - glennw:update-wr-bs-line, r=mbrubeck
Loading status checks…
d9a12a7 
Update WR (inset box shadow fix, line decoration optimizations)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19725)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

💔 Test failed - linux-rel-wpt
@tigercosmos
Copy link
Collaborator

tigercosmos commented Jan 9, 2018 

{"status": "CRASH", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_mozilla/mozilla/referrer-policy/no-referrer/attr-referrer/same-origin/http-https/a-tag/generic.no-redirect.http.html", "line": 143789, "action": "test_result", "expected": "OK"}
@tigercosmos
tigercosmos reviewed Jan 9, 2018
View changes
Cargo.lock
@@ -3595,7 +3595,7 @@ dependencies = [
[[package]]
name = "webrender_api"
version = "0.56.1"
source = "git+https://github.com/servo/webrender#a21197eb1e427730c7bec6eec07bc6cc352d452e"
source = "git+https://github.com/servo/webrender#007c61df33081caec1163db17305ccc191da7d99"

This comment has been minimized.

Sign in to view
@tigercosmos

tigercosmos Jan 9, 2018

Collaborator

I am wondering why we just need to change source and don't need to change version?
I thought when it update, it might from 0.56.1 to 0.56.2?

This comment has been minimized.

Sign in to view
@emilio

emilio Jan 9, 2018

Member

It's a git dependency, there's no need for versions.

This comment has been minimized.

Sign in to view
@tigercosmos

tigercosmos Jan 9, 2018

Collaborator

I am confused. So, when will the version change?

This comment has been minimized.

Sign in to view
@KiChjang

KiChjang Jan 9, 2018

Member

It's updating the commit hash in which the package should be pulled and build from, so no version changes are necessary.

This comment has been minimized.

Sign in to view
@KiChjang

KiChjang Jan 9, 2018

Member

If you're wondering about the version string itself, the Cargo.toml corresponding to that commit hash hasn't change its version (it's still 0.56.1), so there's no update.
@jdm
Copy link
Member

jdm commented Jan 9, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

⌛ Testing commit acf1244 with merge d980019...
bors-servo added a commit that referenced this pull request Jan 9, 2018
@bors-servo
Auto merge of #19725 - glennw:update-wr-bs-line, r=mbrubeck
Loading status checks…
d980019 
Update WR (inset box shadow fix, line decoration optimizations)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19725)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

💔 Test failed - mac-dev-unit
@CYBAI
Copy link
Collaborator

CYBAI commented Jan 9, 2018

Failed with #19495
@jdm
Copy link
Member

jdm commented Jan 9, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-dev-unit...
@jdm
Copy link
Member

jdm commented Jan 9, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: mbrubeck
Pushing d980019 to master...
@bors-servo bors-servo merged commit acf1244 into servo:master Jan 9, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

@KiChjang KiChjang

@tigercosmos tigercosmos

Assignees

@mbrubeck mbrubeck

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
@glennw @mbrubeck @bors-servo @tigercosmos @jdm @CYBAI @emilio @KiChjang @highfive @gw3583
You can’t perform that action at this time.