Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gentoo Linux setup to include clang #19732

Merged
merged 1 commit into from Jan 10, 2018
Merged

Conversation

@gootorov
Copy link
Contributor

gootorov commented Jan 9, 2018

While other Linux distributions include clang package as required in the setup section of README, Gentoo does not. This patch fixes it.
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because it is a documentation fix

This change is Reviewable

@highfive
Copy link

highfive commented Jan 9, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@jdm
Copy link
Member

jdm commented Jan 9, 2018

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

📌 Commit 457c3de has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

Testing commit 457c3de with merge d0300ff...

bors-servo added a commit that referenced this pull request Jan 9, 2018
Update Gentoo Linux setup to include clang

<!-- Please describe your changes on the following line: -->While other Linux distributions include clang package as required in the setup section of README, Gentoo does not. This patch fixes it.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a documentation fix

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19732)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

💔 Test failed - mac-rel-wpt2

@jdm
Copy link
Member

jdm commented Jan 9, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2018

@bors-servo bors-servo merged commit 457c3de into servo:master Jan 10, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.