Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd note to Gentoo setup to set LIBCLANG_PATH envvar #19739
Merged
Conversation
highfive
commented
Jan 10, 2018
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 10, 2018
Add note to Gentoo setup to set LIBCLANG_PATH envvar <!-- Please describe your changes on the following line: --> Without `LIBCLANG_PATH` environment variable set the build for `gecko-media` fails as in #19351 for Gentoo Linux. This patch adds a note to the README to set the environment variable. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it is a documentation fix <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19739) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gootorov commentedJan 10, 2018
•
edited
Without
LIBCLANG_PATHenvironment variable set the build forgecko-mediafails as in #19351 for Gentoo Linux. This patch adds a note to the README to set the environment variable../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is