Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the ability to disable incremental compilation #19763

Merged
merged 4 commits into from Jan 18, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

servobuild: comment some more on the default value

  • Loading branch information
SimonSapin committed Jan 16, 2018
commit 9ec53344f5e4895e24d6b4df7bbf49470c060a51
@@ -41,7 +41,10 @@ debug-mozjs = false
#rustflags = ""

# Enable or disable rustc’s incremental compilation
# The default is enabled in debug mode only.
# Cargo’s default is to enable it in debug mode but not in release mode.
# Leaving this key unspecified makes mach keep Cargo’s default.
# It can be set to true or false in order to always enable or always disable
# incremental compilation.
#incremental = false
#incremental = true

This comment has been minimized.

@nox

nox Jan 15, 2018

Member

Having both is a bit weird.

This comment has been minimized.

@SimonSapin

SimonSapin Jan 15, 2018

Author Member

I suppose it’s not clear enough, but the intent is to show that leaving it out of the config file is a third behavior different from true or false. (It’s None in Python. Does TOML have explicit null values? I don’t find it in https://github.com/toml-lang/toml.)

Another option might be to make the "debug" string that third value, or something.


ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.