Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplayout: Simplify the pseudo-element setup. #19769
Merged
Conversation
…o-element. We only override it when there's no "open" attribute. But a display: none pseudo-element is the same as no pseudo-element at all. This should get the same behavior when iterating children in dom_wrapper.rs
Everyone passes None now.
Everyone uses () now.
…ng::fragment_type.
highfive
commented
Jan 14, 2018
|
|
|
@bors-servo try |
|
r? @mbrubeck |
bors-servo
added a commit
that referenced
this pull request
Jan 14, 2018
layout: Simplify the pseudo-element setup. It's kind of a mess. See individual commits for details.
|
|
|
Those two failures are due to the last commit, but it's a pre-existing bug (#19771). Will undo it for now, leaving a comment. |
emilio
force-pushed the
emilio:simplify-layout-construct
branch
from
03208ba
to
95edda9
|
The last commit that caught that was emilio@03208ba, fwiw. |
|
@bors-servo r+ Neat. |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 15, 2018
layout: Simplify the pseudo-element setup. It's kind of a mess. See individual commits for details. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19769) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedJan 14, 2018
•
edited by SimonSapin
It's kind of a mess. See individual commits for details.
This change is