Remove gecko-media dependency #19806

ferjm · 2018-01-18T13:59:54Z

The effort to import Gecko's media stack into Servo has been canceled, so I am removing the bits of code from gecko-media that we added to Servo.

./mach build -d does not report any errors
./mach test-tidy does not report any errors

This change is

highfive · 2018-01-18T13:59:58Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/lib.rs, components/script/Cargo.toml, components/script/dom/htmlmediaelement.rs
@aneeshusa: etc/ci/buildbot_steps.yml
@edunham: .travis.yml
@fitzgen: components/script/lib.rs, components/script/Cargo.toml, components/script/dom/htmlmediaelement.rs
@KiChjang: components/script/lib.rs, components/script/Cargo.toml, components/script/dom/htmlmediaelement.rs

ferjm · 2018-01-18T14:00:04Z

r? @nox

ferjm · 2018-01-18T14:09:29Z

@bors-servo try

bors-servo · 2018-01-18T14:09:35Z

⌛ Trying commit 2abd0bb with merge e601a73...


        Auto merge of #19806 - ferjm:rm-gecko-media, r=<try>

Remove gecko-media dependency The effort to import Gecko's media stack into Servo has been canceled, so I am removing the bits of code from gecko-media that we added to Servo. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19806)

nox · 2018-01-18T14:12:59Z

@bors-servo r+

bors-servo · 2018-01-18T14:12:59Z

📌 Commit 2abd0bb has been approved by nox

bors-servo · 2018-01-18T15:37:32Z

☔ The latest upstream changes (presumably #19713) made this pull request unmergeable. Please resolve the merge conflicts.

tigercosmos · 2018-01-18T15:41:40Z

I thought dependencies in README also need to remove?

many are for gecko-media, such as clang

bors-servo · 2018-01-18T15:44:06Z

🔒 Merge conflict

LifeIsStrange · 2018-01-18T16:17:31Z

By curiosity, could you explain why ?
Importing the media stack would have skyrocketted servo in it's goal of being usable on a daily basis.

metajack · 2018-01-18T18:27:09Z

There were some internal projects that were driving some of the investment there, and those shifted focus a bit. We'd still love to have a media stack in Servo, but the accelerated time frame is no longer viable. In order to keep pushing for media in Servo, it may make sense to use gstreamer as the basis instead, which is already built to be used by many projects.

LifeIsStrange · 2018-01-18T20:32:36Z

@metajack "the investment" , english is not my native language, but if by investment you mean monetary investment, I suggest you , the servo team, to do a crowdfunding campaign, your project is exciting by so many ways, not just by the technical challenges (that would motivate many geeks/devs to give) you tackle, but by 1) allowing unprecedent performance on slow devices e.g third world and smartphones/WOT and that would interest many heavy web users.... and by 2) a side effect, allowing new kind of rich websites that would have been too slow before. And that would interest a lot of firms, enabling new markets.

So I don't really think investment would be anymore an issue for servo.

jdm · 2018-01-18T22:10:32Z

By investment, we mean the time spent by Mozilla employees on that project.

LifeIsStrange · 2018-01-18T22:58:38Z

@jdm Yes but new funds from Crowdfunfing could allow to hire new devs maybe ?
Also mozilla could ask to some big firms like Facebook/amazon/Netflix/etc to invest in servo because it's in their interest to have far faster sites. And it has already been done by Facebook for mozjpeg ! They gave 60000 $ to mozilla and mozjpeg has far less economical impact than servo !
Source : http://www.clubic.com/internet/actualite-715615-mozilla-mozjpeg-2-jpeg-plus-leger-soutien-facebook.html (sorry in french).

ferjm · 2018-01-19T08:09:36Z

@bors-servo try

bors-servo · 2018-01-19T08:09:40Z

⌛ Trying commit 7bd4aca with merge 52b24f5...


        Auto merge of #19806 - ferjm:rm-gecko-media, r=<try>

Remove gecko-media dependency The effort to import Gecko's media stack into Servo has been canceled, so I am removing the bits of code from gecko-media that we added to Servo. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19806)

bors-servo · 2018-01-19T08:10:00Z

💔 Test failed - linux-rel-wpt

bors-servo · 2018-01-19T15:30:11Z

⌛ Testing commit f46fbe4 with merge d908582...


        Auto merge of #19806 - ferjm:rm-gecko-media, r=nox

Remove gecko-media dependency The effort to import Gecko's media stack into Servo has been canceled, so I am removing the bits of code from gecko-media that we added to Servo. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19806)

bors-servo · 2018-01-19T15:30:41Z

💔 Test failed - windows-msvc-dev

SimonSapin · 2018-01-19T15:32:14Z

error: failed to load source for a dependency on `webrender_api`

Caused by:
  Unable to update https://github.com/servo/webrender#2547f6fe

Caused by:
  Couldn't rmdir C:\Users\Administrator\.cargo\git\checkouts\webrender-c3596abe1cf4f320\2547f6f

Caused by:
  Access is denied. (os error 5)

Are builders stuck in a bad state?

SimonSapin · 2018-01-19T15:46:22Z

Should be fixed now (thanks jdm)

@bors-servo retry

bors-servo · 2018-01-19T16:11:02Z

⌛ Testing commit f46fbe4 with merge b02017d...


        Auto merge of #19806 - ferjm:rm-gecko-media, r=nox

Remove gecko-media dependency The effort to import Gecko's media stack into Servo has been canceled, so I am removing the bits of code from gecko-media that we added to Servo. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19806)

bors-servo · 2018-01-19T16:11:34Z

💔 Test failed - windows-msvc-dev

jdm · 2018-01-19T17:53:24Z

@bors-servo retry

bors-servo · 2018-01-19T17:53:29Z

⌛ Testing commit f46fbe4 with merge acdbbd5...


        Auto merge of #19806 - ferjm:rm-gecko-media, r=nox

Remove gecko-media dependency The effort to import Gecko's media stack into Servo has been canceled, so I am removing the bits of code from gecko-media that we added to Servo. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19806)

bors-servo · 2018-01-19T18:49:55Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing acdbbd5 to master...


        Remove some now-unnecessary dependencies

servo/servo#19806

highfive assigned Manishearth Jan 18, 2018

highfive added the S-awaiting-review label Jan 18, 2018

highfive assigned nox and unassigned Manishearth Jan 18, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 18, 2018

highfive added S-needs-rebase and removed S-awaiting-merge labels Jan 18, 2018

ferjm force-pushed the ferjm:rm-gecko-media branch from 2abd0bb to 7bd4aca Jan 19, 2018

highfive added the S-awaiting-review label Jan 19, 2018

highfive added the S-tests-failed label Jan 19, 2018

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Jan 19, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 19, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 19, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 19, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 19, 2018

jdm mentioned this pull request Jan 19, 2018

mutation_test.sh fails due to a missing file or directory #19821

Closed

bors-servo merged commit f46fbe4 into servo:master Jan 19, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jan 19, 2018

bors-servo mentioned this pull request Jan 19, 2018

WIP (Do not merge) Media stuff #19521

Closed

SimonSapin added a commit to servo/servo-with-rust-nightly that referenced this pull request Jan 19, 2018

Remove some now-unnecessary dependencies

Loading status checks…

0553114

servo/servo#19806

pyfisch mentioned this pull request Jan 20, 2018

Servo build fails at linking #19543

Closed

ferjm deleted the ferjm:rm-gecko-media branch Jan 22, 2018

servo / servo

Remove gecko-media dependency #19806

Remove gecko-media dependency #19806

ferjm commented Jan 18, 2018 •

edited by SimonSapin

highfive commented Jan 18, 2018

ferjm commented Jan 18, 2018

ferjm commented Jan 18, 2018

bors-servo commented Jan 18, 2018

nox commented Jan 18, 2018

bors-servo commented Jan 18, 2018

bors-servo commented Jan 18, 2018

tigercosmos commented Jan 18, 2018 •

edited

bors-servo commented Jan 18, 2018

LifeIsStrange commented Jan 18, 2018

metajack commented Jan 18, 2018

LifeIsStrange commented Jan 18, 2018 •

edited

jdm commented Jan 18, 2018

LifeIsStrange commented Jan 18, 2018

ferjm commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

SimonSapin commented Jan 19, 2018

SimonSapin commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

jdm commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

servo / servo

Join GitHub today

Remove gecko-media dependency #19806

Remove gecko-media dependency #19806

Conversation

ferjm commented Jan 18, 2018 • edited by SimonSapin

highfive commented Jan 18, 2018

ferjm commented Jan 18, 2018

ferjm commented Jan 18, 2018

bors-servo commented Jan 18, 2018

nox commented Jan 18, 2018

bors-servo commented Jan 18, 2018

bors-servo commented Jan 18, 2018

tigercosmos commented Jan 18, 2018 • edited

bors-servo commented Jan 18, 2018

LifeIsStrange commented Jan 18, 2018

metajack commented Jan 18, 2018

LifeIsStrange commented Jan 18, 2018 • edited

jdm commented Jan 18, 2018

LifeIsStrange commented Jan 18, 2018

ferjm commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

SimonSapin commented Jan 19, 2018

SimonSapin commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

jdm commented Jan 19, 2018

bors-servo commented Jan 19, 2018

bors-servo commented Jan 19, 2018

ferjm commented Jan 18, 2018 •

edited by SimonSapin

tigercosmos commented Jan 18, 2018 •

edited

LifeIsStrange commented Jan 18, 2018 •

edited