Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (minimal use of new transaction API). #19814

Merged
merged 1 commit into from Jan 19, 2018

Conversation

@glennw
Copy link
Member

commented Jan 19, 2018

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jan 19, 2018

Heads up! This PR modifies the following files:

@glennw

This comment has been minimized.

Copy link
Member Author

commented Jan 19, 2018

r? @jdm or @emilio

The non-transaction API in WR is deprecated and removed. So even though we're not actually using transactions properly in Servo, we need to wrap up WR API calls in a transaction now.

@emilio

This comment has been minimized.

Copy link
Member

commented Jan 19, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

📌 Commit 800a66f has been approved by emilio

@highfive highfive assigned emilio and unassigned jdm Jan 19, 2018
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

⌛️ Testing commit 800a66f with merge bd4cb04...

bors-servo added a commit that referenced this pull request Jan 19, 2018
Update WR (minimal use of new transaction API).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19814)
<!-- Reviewable:end -->
@emilio
emilio approved these changes Jan 19, 2018
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

⌛️ Testing commit 800a66f with merge 0434677...

bors-servo added a commit that referenced this pull request Jan 19, 2018
Update WR (minimal use of new transaction API).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19814)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

💔 Test failed - windows-msvc-dev

@jdm

This comment has been minimized.

Copy link
Member

commented Jan 19, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

⌛️ Testing commit 800a66f with merge 54f3133...

bors-servo added a commit that referenced this pull request Jan 19, 2018
Update WR (minimal use of new transaction API).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19814)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

💔 Test failed - windows-msvc-dev

@jdm

This comment has been minimized.

Copy link
Member

commented Jan 19, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

⌛️ Testing commit 800a66f with merge 727dafc...

bors-servo added a commit that referenced this pull request Jan 19, 2018
Update WR (minimal use of new transaction API).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19814)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

💔 Test failed - windows-msvc-dev

@jdm

This comment has been minimized.

Copy link
Member

commented Jan 19, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

⌛️ Testing commit 800a66f with merge 0b86b60...

bors-servo added a commit that referenced this pull request Jan 19, 2018
Update WR (minimal use of new transaction API).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19814)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Copy link
Member

commented Jan 19, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Copy link
Member

commented Jan 19, 2018

@bors-servo treeclosed+
Just controlling some variables to help clean up our CI.

@jdm

This comment has been minimized.

Copy link
Member

commented Jan 19, 2018

@bors-servo treeclosed=8000

@jdm

This comment has been minimized.

Copy link
Member

commented Jan 19, 2018

@bors-servo treeclosed- retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

@bors-servo bors-servo merged commit 800a66f into servo:master Jan 19, 2018
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.