Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run servo-warc-tests as part of test-perf #19820

Merged
merged 1 commit into from Jan 24, 2018

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jan 19, 2018

Run the servo-warc-tests as part of performance testing.

Depends on servo/servo-warc-tests#1


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because this is adding more test infrastructure

This change is Reviewable

@highfive
Copy link

highfive commented Jan 19, 2018

Heads up! This PR modifies the following files:

  • @aneeshusa: etc/ci/performance/.gitignore, etc/ci/performance/test_perf.sh
@asajeffrey
Copy link
Member Author

asajeffrey commented Jan 19, 2018

r? @jdm

@highfive highfive assigned jdm and unassigned pcwalton Jan 19, 2018
@asajeffrey
Copy link
Member Author

asajeffrey commented Jan 19, 2018

We'll need to install proxychains on the linux builders before merging this.

@jdm
Copy link
Member

jdm commented Jan 23, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2018

📌 Commit c3e2ce0 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2018

Testing commit c3e2ce0 with merge 2024ef5...

bors-servo added a commit that referenced this pull request Jan 23, 2018
Run servo-warc-tests as part of test-perf

<!-- Please describe your changes on the following line: -->

Run the servo-warc-tests as part of performance testing.

Depends on servo/servo-warc-tests#1

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is adding more test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19820)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2018

@bors-servo bors-servo merged commit c3e2ce0 into servo:master Jan 24, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@asajeffrey
Copy link
Member Author

asajeffrey commented Jan 24, 2018

Now we get to see if we have live performance data on archived web content!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.