Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Remove -moz-border-*-colors. #19833

Merged
merged 2 commits into from Jan 22, 2018
Merged

Conversation

@emilio
Copy link
Member

emilio commented Jan 22, 2018

Bug: 1429723
Reviewed-by: xidorn
MozReview-Commit-ID: 3P6f7rFcDa6


This change is Reviewable

emilio added 2 commits Jan 15, 2018
Bug: 1429723
Reviewed-by: xidorn
MozReview-Commit-ID: 3P6f7rFcDa6
@highfive
Copy link

highfive commented Jan 22, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/properties/gecko.mako.rs, components/style/properties/properties.mako.rs, components/style/gecko/generated/structs.rs, components/style/properties/longhand/border.mako.rs
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/properties/gecko.mako.rs, components/style/properties/properties.mako.rs, components/style/gecko/generated/structs.rs, components/style/properties/longhand/border.mako.rs
@highfive
Copy link

highfive commented Jan 22, 2018

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Jan 22, 2018

@bors-servo r=xidorn

@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

📌 Commit 1183b47 has been approved by xidorn

@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

Testing commit 1183b47 with merge abb04ce...

bors-servo added a commit that referenced this pull request Jan 22, 2018
style: Remove -moz-border-*-colors.

Bug: 1429723
Reviewed-by: xidorn
MozReview-Commit-ID: 3P6f7rFcDa6

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19833)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

💔 Test failed - linux-rel-css

@CYBAI
Copy link
Collaborator

CYBAI commented Jan 22, 2018

From filtered-wpt-errorsummary.log:

{"status": "CRASH", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/syntax/parsing/html5lib_ruby.html?run_type=uri", "line": 86087, "action": "test_result", "expected": "OK"}

From intermittents.log:

{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_mozilla/css/iframe/hide_after_load.html", "line": 19895, "action": "test_result", "expected": "PASS"}
{"status": "FAIL", "group": "default", "message": "/_mozilla/mozilla/simple_scroll_to_fragment.html 2d5103c1d79069b6628ffe931d05456e5b9244b2\n/_mozilla/mozilla/simple_scroll_to_fragment_ref.html 7949e80732fa0f4afdbae3b1cad96ccd75bb04f6\nTesting 2d5103c1d79069b6628ffe931d05456e5b9244b2 == 7949e80732fa0f4afdbae3b1cad96ccd75bb04f6", "stack": null, "subtest": null, "test": "/_mozilla/mozilla/simple_scroll_to_fragment.html", "line": 29588, "action": "test_result", "expected": "PASS"}
{"status": "FAIL", "group": "default", "message": "assert_greater_than_equal: expected a number greater than or equal to 100 but got 99", "stack": "@http://web-platform.test:8000/_mozilla/mozilla/promise.html:64:11\n", "subtest": "Native promise from async callback can be resolved", "test": "/_mozilla/mozilla/promise.html", "line": 104484, "action": "test_result", "expected": "PASS"}
{"status": "CRASH", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_mozilla/webgl/conformance-1.0.3/conformance/glsl/bugs/long-expressions-should-not-crash.html", "line": 108798, "action": "test_result", "expected": "TIMEOUT"}
{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_mozilla/webgl/conformance-1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html", "line": 141699, "action": "test_result", "expected": "OK"}
@jdm
Copy link
Member

jdm commented Jan 22, 2018

That's #13479.

@jdm
Copy link
Member

jdm commented Jan 22, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

@emilio
Copy link
Member Author

emilio commented Jan 22, 2018

The only non-intermittent failure there (the first), is the "connection reset by peer" one (#13480).

@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

@bors-servo bors-servo merged commit 1183b47 into servo:master Jan 22, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.