Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTest for #18544 - Flow list crash #19834
Merged
Conversation
|
r? @emilio |
|
r=me, with that. Thanks! |
| <script> | ||
| async_test(function(test) { | ||
| window.onload = test.step_func_done(function() { | ||
| document.body.children[0].style['column-count'] = 1; |
This comment has been minimized.
This comment has been minimized.
emilio
Jan 22, 2018
Member
let's do document.body.offsetTop; below this line so we're sure that layout has been triggered before reporting the test as ok.
|
LGTM, thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 23, 2018
Test for #18544 - Flow list crash - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18544 - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19834) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJan 22, 2018
•
edited by SimonSapin
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is