Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inline stylesheet parsing out of HTML parser. #1984

Merged
merged 1 commit into from Apr 14, 2014
Merged

Move inline stylesheet parsing out of HTML parser. #1984

merged 1 commit into from Apr 14, 2014

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Mar 26, 2014

This is a partial fix for #1959. This commit only addresses inline <style> elements. Next I will need to move <link rel="stylesheet"> handling into shared code, but I wanted to get some early feedback on this piece first.
src/components/script/dom/element.rs Outdated
@@ -644,6 +646,19 @@ impl IElement for JS<Element> {
}
}

pub fn parse_css_from_element(node: &JS<Node>) {

This comment has been minimized.

Sign in to view
Copy link
@mbrubeck

mbrubeck Mar 26, 2014

Author Contributor

I wasn't sure if this should live in script::html::cssparse, or maybe in one of the Element/Node traits...
src/components/script/dom/node.rs Outdated
@@ -505,6 +509,13 @@ impl NodeHelpers for JS<Node> {
child_node.set_parent_node(None);
}

fn notify_child_list_changed(&self) {

This comment has been minimized.

Sign in to view
Copy link
@mbrubeck

mbrubeck Mar 26, 2014

Author Contributor

This special-case function could later be replaced by mutation observers (#1980).
@jdm jdm closed this Mar 26, 2014
@jdm jdm reopened this Mar 26, 2014
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 26, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1102

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@mbrubeck mbrubeck mentioned this pull request Apr 1, 2014
Closed
@jdm
Copy link
Member

jdm commented Apr 5, 2014

This now requires a rebase, unfortunately.
@mbrubeck mbrubeck self-assigned this Apr 7, 2014
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Apr 10, 2014

r? @Ms2ger
@mbrubeck
Move inline stylesheet parsing out of HTML parser.
Loading status checks…
8c794c6 
Instead, use shared code to parse stylesheet content when it is inserted,
whether during parsing or dynamically by script.

Based on work by sanools in #1350.
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link

Ms2ger commented on 8c794c6 Apr 14, 2014

r=jdm,Ms2ger
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 8c794c6 Apr 14, 2014

saw approval from jdm
at mbrubeck@8c794c6

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 14, 2014

merging mbrubeck/servo/1959-parser-style = 8c794c6 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 14, 2014

mbrubeck/servo/1959-parser-style = 8c794c6 merged ok, testing candidate = 18b5453

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 14, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1209
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1163

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 14, 2014

fast-forwarding master to auto = 18b5453
bors-servo pushed a commit that referenced this pull request Apr 14, 2014
bors-servo
auto merge of #1984 : mbrubeck/servo/1959-parser-style, r=jdm
18b5453 
This is a partial fix for #1959.  This commit only addresses inline `<style>` elements.  Next I will need to move `<link rel="stylesheet">` handling into shared code, but I wanted to get some early feedback on this piece first.
@bors-servo bors-servo merged commit 8c794c6 into servo:master Apr 14, 2014
1 check passed
1 check passed
default all tests passed
mbrubeck added a commit to mbrubeck/servo that referenced this pull request Apr 14, 2014
@mbrubeck
Move child_inserted into VirtualMethods.
28a013c 
Follow-up from servo#1984.
@mbrubeck mbrubeck mentioned this pull request Apr 14, 2014
Merged
bors-servo pushed a commit that referenced this pull request Apr 14, 2014
bors-servo
auto merge of #2106 : mbrubeck/servo/1959-vtable-followup, r=jdm
6720b81 
Follow-up from #1984. r? @jdm
@jdm jdm mentioned this pull request Sep 16, 2014
Closed
6 of 6 tasks complete
@mbrubeck mbrubeck deleted the mbrubeck:1959-parser-style branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mbrubeck @hoppipolla-critic-bot @jdm @bors-servo @Ms2ger
You can’t perform that action at this time.