Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Avoid separate monomorphizations of CSS serialization for utf-8 and utf-16 #19841

Merged
merged 2 commits into from Jan 22, 2018
Merged

stylo: Avoid separate monomorphizations of CSS serialization for utf-8 and utf-16 #19841

merged 2 commits into from Jan 22, 2018

Conversation

@bholley
Copy link
Contributor

bholley commented Jan 22, 2018 •
edited by SimonSapin

https://bugzilla.mozilla.org/show_bug.cgi?id=1431268

This change is Reviewable
@bholley
Avoid some unnecessary intermediate utf8 strings in glue.rs.
f5dd50d 
MozReview-Commit-ID: 79qv87uPzjR
@highfive
Copy link

highfive commented Jan 22, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/cssstyledeclaration.rs
  • @canaltinova: components/style/stylesheets/font_feature_values_rule.rs, components/style/stylesheets/page_rule.rs, components/style/stylesheets/import_rule.rs, components/style/stylesheets/viewport_rule.rs, components/style/stylesheets/rule_list.rs and 14 more
  • @KiChjang: components/script/dom/cssstyledeclaration.rs
  • @fitzgen: components/script/dom/cssstyledeclaration.rs
  • @emilio: components/style/stylesheets/font_feature_values_rule.rs, components/style/stylesheets/page_rule.rs, components/style/stylesheets/import_rule.rs, components/style/stylesheets/viewport_rule.rs, components/style/stylesheets/rule_list.rs and 15 more
@highfive
Copy link

highfive commented Jan 22, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and script code, but no tests are modified. Please consider adding a test!
@bholley
Copy link
Contributor Author

bholley commented Jan 22, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

📌 Commit c84cc39 has been approved by emilio
@highfive highfive assigned emilio and unassigned KiChjang Jan 22, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

⌛ Testing commit c84cc39 with merge abfc043...
bors-servo added a commit that referenced this pull request Jan 22, 2018
@bors-servo
Auto merge of #19841 - bholley:single_tocss, r=emilio
Loading status checks…
abfc043 
stylo: Avoid separate monomorphizations of CSS serialization for utf-8 and utf-16

https://bugzilla.mozilla.org/show_bug.cgi?id=1431268
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

💔 Test failed - linux-dev
@bholley
Avoid the generic writer parameter for PropertyDeclaration serializat…
Loading status checks…
5526947 
…ion.

MozReview-Commit-ID: JR3IcL1NRHO
@bholley bholley force-pushed the bholley:single_tocss branch from c84cc39 to 5526947 Jan 22, 2018
@bholley
Copy link
Contributor Author

bholley commented Jan 22, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

📌 Commit 5526947 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

⌛ Testing commit 5526947 with merge 6f543d3...
bors-servo added a commit that referenced this pull request Jan 22, 2018
@bors-servo
Auto merge of #19841 - bholley:single_tocss, r=emilio
Loading status checks…
6f543d3 
stylo: Avoid separate monomorphizations of CSS serialization for utf-8 and utf-16

https://bugzilla.mozilla.org/show_bug.cgi?id=1431268

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 6f543d3 to master...
@bors-servo bors-servo merged commit 5526947 into servo:master Jan 22, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 22, 2018
Merged
@ionutgoldan
Copy link

ionutgoldan commented Jan 25, 2018

Looks like build times reduced a bit thanks to this!

== Change summary for alert #11252 (as of Mon, 22 Jan 2018 21:53:50 GMT) ==

Improvements:

5% build times windows2012-64 opt static-analysis taskcluster-c4.4xlarge 2,702.03 -> 2,570.60
5% build times windows2012-32 opt static-analysis taskcluster-c4.4xlarge 2,359.76 -> 2,250.44

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@bholley @highfive @bors-servo @ionutgoldan @emilio @KiChjang
You can’t perform that action at this time.