Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded default fall-back when CARGO_HOME is not set for clean-cargo-cache #19843
Conversation
highfive
commented
Jan 23, 2018
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon. |
highfive
commented
Jan 23, 2018
|
Heads up! This PR modifies the following files:
|
|
Let me know if I should fix anything :) Edit: it seems like some of the tests are failing, namely on windows:
Is it because .cargo location on windows is in the appdata? More edit: I see that other PR's have similar issue |
|
It seems after #19831 is fixed this should work fine. It seems jdm already proposed a pull request |
|
@terracotaPie Seems not work? AppVeyor Log
|
|
@tigercosmos other PRs have the same error. There is a fix which I will rebase as soon as it gets into master #19832 |
|
@terracotaPie Ah! Sorry. I misunderstand that this PR can also fix that issue. |
|
@tigercosmos No worries. I'll wait for the PR to be in master and then rebase. Would you mind reviewing then? |
|
@bors-servo r+ |
|
|
Added default fall-back when CARGO_HOME is not set for clean-cargo-cache Added default fall-back when CARGO_HOME is not set. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19823 (github issue number if applicable). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19843) <!-- Reviewable:end -->
|
|
terracotaPie commentedJan 23, 2018
•
edited by SimonSapin
Added default fall-back when CARGO_HOME is not set.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is