New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow floats to impact list item marker position #19852

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
6 participants
@jonleighton
Contributor

jonleighton commented Jan 24, 2018

Although not required by the specification, this matches the rendering
of Gecko and Blink.

Fixes #19796.


This change is Reviewable

Allow floats to impact list item marker position
Although not required by the specification, this matches the rendering
of Gecko and Blink.

Fixes #19796.
@highfive

This comment has been minimized.

highfive commented Jan 24, 2018

Heads up! This PR modifies the following files:

  • @emilio: components/layout/list_item.rs
@emilio

This comment has been minimized.

Member

emilio commented Jan 24, 2018

@highfive highfive assigned mbrubeck and unassigned jdm Jan 24, 2018

@mbrubeck

This comment has been minimized.

Contributor

mbrubeck commented Jan 24, 2018

@bors-servo r+

Thanks!

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jan 24, 2018

📌 Commit 84713df has been approved by mbrubeck

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jan 25, 2018

⌛️ Testing commit 84713df with merge d974411...

bors-servo added a commit that referenced this pull request Jan 25, 2018

Auto merge of #19852 - jonleighton:issue-19796, r=mbrubeck
Allow floats to impact list item marker position

Although not required by the specification, this matches the rendering
of Gecko and Blink.

Fixes #19796.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19852)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jan 25, 2018

@bors-servo bors-servo merged commit 84713df into servo:master Jan 25, 2018

2 of 4 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment