Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSTraceable for DomRefCell<T> panic if cell is mutably borrowed #19872

Merged
merged 1 commit into from Jan 26, 2018
Merged

Make JSTraceable for DomRefCell<T> panic if cell is mutably borrowed #19872

merged 1 commit into from Jan 26, 2018

Conversation

@nox
Copy link
Member

nox commented Jan 26, 2018 •
edited by SimonSapin

This change is Reviewable
@nox
Make JSTraceable for DomRefCell<T> panic if cell is mutably borrowed …
Loading status checks…
31a1408 
…(see #19871)
@highfive
Copy link

highfive commented Jan 26, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/cell.rs, components/script/dom/bindings/trace.rs
  • @fitzgen: components/script/dom/bindings/cell.rs, components/script/dom/bindings/trace.rs
  • @KiChjang: components/script/dom/bindings/cell.rs, components/script/dom/bindings/trace.rs
@highfive
Copy link

highfive commented Jan 26, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Jan 26, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jan 26, 2018

⌛ Trying commit 31a1408 with merge d976704...
bors-servo added a commit that referenced this pull request Jan 26, 2018
@bors-servo
Auto merge of #19872 - nox:domrefcell-tracing, r=<try>
Loading status checks…
d976704 
(Do not merge) Make JSTraceable for DomRefCell<T> panic if cell is mutably borrowed

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19872)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 26, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@nox
Copy link
Member Author

nox commented Jan 26, 2018

INCREDIBRU, I did not expect this to succeed.
@emilio
Copy link
Member

emilio commented Jan 26, 2018

:shipit:?
@jdm
Copy link
Member

jdm commented Jan 26, 2018

Yeah, this is probably the right choice.
@nox
Copy link
Member Author

nox commented Jan 26, 2018

@jdm r=you?
@nox nox changed the title (Do not merge) Make JSTraceable for DomRefCell<T> panic if cell is mutably borrowed Make JSTraceable for DomRefCell<T> panic if cell is mutably borrowed Jan 26, 2018
@jdm
Copy link
Member

jdm commented Jan 26, 2018

R=me
@nox
Copy link
Member Author

nox commented Jan 26, 2018

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 26, 2018

📌 Commit 31a1408 has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Jan 26, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jan 26, 2018

⌛ Testing commit 31a1408 with merge c0d9f28...
bors-servo added a commit that referenced this pull request Jan 26, 2018
@bors-servo
Auto merge of #19872 - nox:domrefcell-tracing, r=jdm
Loading status checks…
c0d9f28 
Make JSTraceable for DomRefCell<T> panic if cell is mutably borrowed

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19872)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 26, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing c0d9f28 to master...
@bors-servo bors-servo merged commit 31a1408 into servo:master Jan 26, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Feb 20, 2018
Open
@jdm jdm mentioned this pull request Mar 18, 2018
Merged
3 of 5 tasks complete
@nox nox mentioned this pull request Mar 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @bors-servo @emilio @jdm @Manishearth
You can’t perform that action at this time.