Acid2 2 #1988

pcwalton · 2014-03-28T21:31:04Z

r? @metajack @SimonSapin @larsbergstrom @june0cho @hyunjunekim

highfive · 2014-03-28T21:31:06Z

Warning

These commits modify unsafe code. Please review it carefully!
@pcwalton, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!

hoppipolla-critic-bot · 2014-03-28T21:31:11Z

Critic review: https://critic.hoppipolla.co.uk/r/1120

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

larsbergstrom · 2014-03-28T21:34:31Z

Comment from previous PR detailing areas for review:

r? @SimonSapin (style stuff and whatever you'd feel like), @larsbergstrom (graphics and whatever else you'd like), @metajack (whatever you'd like) @june0cho (tables), @hyunjunekim (pseudo-elements)

pcwalton · 2014-03-31T22:55:26Z

Comments addressed. re-r? @SimonSapin @larsbergstrom et al


        Adress more servo#1988 (Acid 2) review comments.


        fixup! Adress more servo#1988 (Acid 2) review comments.


        Adress more servo#1988 (Acid 2) review comments.


        style: Parse `min-height` and `max-height`


        style: Implement `-servo-minimum-line-height`, a derived property from

`line-height`, and the infrastructure needed for derived properties to work. Eventually I would like this to be used for text decorations, like WebKit does with `-webkit-text-decorations-in-effect`.


        style: Parse `background-position` and `background-attachment`.


        util: Add some utility methods to `SmallVec`.


        util: Add a `rect_contains_point` utility method


        servo: Implement stacking contexts and allow multiple layers per

pipeline. This handles fixed positioning mostly correctly.


        layout: Take `min-height` and `max-height` into account


        layout: Take padding into account for inline boxes


        layout: Update `parallel.rs` to use `OpaqueNodeMethods`


        layout: Support multiple boxes per node; don't store fixed/absolute

descendant links separately


        layout: Implement `-servo-minimum-line-height`


        layout: Rewrite the margin collapse code to work with negative margins.


        layout: Implement enough of automatic table layout to pass Acid2.


        layout: Implement pseudo-elements.


        test: Add many reftests for parts of Acid2.


        support: Update submodules.


        layout: Address review feedback.


        test: Fix some reftests.


        layout: Fix percentages in relatively positioned elements


        layout: Address some more review comments


        layout: Address review comments for `min-height` and `max-height`

computation


        Adress more #1988 (Acid 2) review comments.


        Computed value of 'height: <percentage>' is 'auto' in some cases.

See http://dev.w3.org/csswg/css2/visudet.html#propdef-height This is necessary but not sufficient for #2029. A bug fix in the previous commit "broke" Acid 2 because that bug was hiding this one. This makes Acid 2 pass again.

pcwalton · 2014-04-03T22:37:08Z

r=SimonSapin

larsbergstrom · 2014-04-03T23:39:49Z

@bors: retry

larsbergstrom · 2014-04-04T00:58:22Z

@bors: retry

bors-servo · 2014-04-03T22:40:43Z

saw approval from SimonSapin
at pcwalton@9e3f7a0

bors-servo · 2014-04-03T22:40:46Z

merging pcwalton/servo/acid2-2 = 9e3f7a0 into auto

bors-servo · 2014-04-03T22:40:47Z

pcwalton/servo/acid2-2 = 9e3f7a0 merged ok, testing candidate = 2bb8d37

bors-servo · 2014-04-03T23:16:46Z

some tests failed:
exception: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1107

bors-servo · 2014-04-03T23:55:44Z

saw approval from SimonSapin
at pcwalton@9e3f7a0

bors-servo · 2014-04-04T01:01:44Z

saw approval from SimonSapin
at pcwalton@9e3f7a0

bors-servo · 2014-04-04T01:01:47Z

merging pcwalton/servo/acid2-2 = 9e3f7a0 into auto

bors-servo · 2014-04-04T01:01:48Z

pcwalton/servo/acid2-2 = 9e3f7a0 merged ok, testing candidate = 3ec2215

bors-servo · 2014-04-04T01:22:46Z

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1154
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1109

bors-servo · 2014-04-04T01:25:45Z

fast-forwarding master to auto = 3ec2215


        auto merge of #1988 : pcwalton/servo/acid2-2, r=SimonSapin

@metajack

r? @metajack @SimonSapin @larsbergstrom @june0cho @hyunjunekim


        auto merge of #1988 : pcwalton/servo/acid2-2, r=SimonSapin

@metajack

r? @metajack @SimonSapin @larsbergstrom @june0cho @hyunjunekim


        auto merge of #1988 : pcwalton/servo/acid2-2, r=SimonSapin

@metajack

r? @metajack @SimonSapin @larsbergstrom @june0cho @hyunjunekim


        auto merge of #4619 : mbrubeck/servo/dead-top-margin, r=Ms2ger

@pcwalton

Added in #1988 but never used. r? @pcwalton


        auto merge of #4619 : mbrubeck/servo/dead-top-margin, r=Ms2ger

@pcwalton

Added in #1988 but never used. r? @pcwalton

SimonSapin mentioned this pull request Mar 29, 2014

Use Acid2 as a reftest #1993

Closed

Ms2ger mentioned this pull request Mar 31, 2014

Lots of Acid2 stuff #1987

Closed

This was referenced Mar 31, 2014

background-position: support complete Level 2 syntax #1997

Closed

Implement `background-position` #1784

Closed

Ms2ger mentioned this pull request Apr 1, 2014

Make box_ not Option in block flows.(fixes #2012) #2020

Merged

SimonSapin mentioned this pull request Apr 3, 2014

Support percentage height #2029

Closed

SimonSapin added a commit to SimonSapin/servo that referenced this pull request Apr 3, 2014

Adress more servo#1988 (Acid 2) review comments.

bdc3725

SimonSapin added a commit to SimonSapin/servo that referenced this pull request Apr 3, 2014

fixup! Adress more servo#1988 (Acid 2) review comments.

f9e8df4

SimonSapin added a commit to SimonSapin/servo that referenced this pull request Apr 3, 2014

Adress more servo#1988 (Acid 2) review comments.

3341cc8

pcwalton and others added 17 commits Mar 28, 2014

style: Parse `min-height` and `max-height`

e6adc54

style: Implement `-servo-minimum-line-height`, a derived property from

d136d7a

`line-height`, and the infrastructure needed for derived properties to work. Eventually I would like this to be used for text decorations, like WebKit does with `-webkit-text-decorations-in-effect`.

style: Parse `background-position` and `background-attachment`.

1b04165

util: Add some utility methods to `SmallVec`.

dae4166

util: Add a `rect_contains_point` utility method

f8e3e50

servo: Implement stacking contexts and allow multiple layers per

cd9d824

pipeline. This handles fixed positioning mostly correctly.

layout: Take padding into account for inline boxes

e6665a2

layout: Support multiple boxes per node; don't store fixed/absolute

98bf325

descendant links separately

layout: Rewrite the margin collapse code to work with negative margins.

10aed5b

layout: Implement enough of automatic table layout to pass Acid2.

901c448

layout: Implement pseudo-elements.

4c53a21

test: Add many reftests for parts of Acid2.

42170c7

support: Update submodules.

30b7f5d

layout: Address review feedback.

c49f23f

pcwalton and others added 6 commits Mar 31, 2014

test: Fix some reftests.

2e5b210

layout: Fix percentages in relatively positioned elements

aabda89

layout: Address some more review comments

5609650

layout: Address review comments for `min-height` and `max-height`

9712e6d

computation

Adress more #1988 (Acid 2) review comments.

8e14579

bors-servo pushed a commit that referenced this pull request Apr 3, 2014

auto merge of #1988 : pcwalton/servo/acid2-2, r=SimonSapin

2bb8d37

r? @metajack @SimonSapin @larsbergstrom @june0cho @hyunjunekim

bors-servo pushed a commit that referenced this pull request Apr 3, 2014

auto merge of #1988 : pcwalton/servo/acid2-2, r=SimonSapin

4402d0d

r? @metajack @SimonSapin @larsbergstrom @june0cho @hyunjunekim

bors-servo pushed a commit that referenced this pull request Apr 4, 2014

auto merge of #1988 : pcwalton/servo/acid2-2, r=SimonSapin

3ec2215

r? @metajack @SimonSapin @larsbergstrom @june0cho @hyunjunekim

bors-servo merged commit 9e3f7a0 into servo:master Apr 4, 2014
1 check passed

1 check passed

default all tests passed

This was referenced Apr 4, 2014

Support basic auto table layout calculation. #1982

Closed

Implement pseudo-element(before and after) #1974

Closed

june0cho mentioned this pull request May 24, 2014

ACID2: anonymous table cells not being laid out correctly #1981

Closed

mbrubeck mentioned this pull request Jan 12, 2015

Remove unused Flow method #4619

Merged

bors-servo pushed a commit that referenced this pull request Jan 12, 2015

auto merge of #4619 : mbrubeck/servo/dead-top-margin, r=Ms2ger

Loading status checks…

b892392

Added in #1988 but never used. r? @pcwalton

bors-servo pushed a commit that referenced this pull request Jan 12, 2015

auto merge of #4619 : mbrubeck/servo/dead-top-margin, r=Ms2ger

Loading status checks…

8103bba

Added in #1988 but never used. r? @pcwalton

servo / servo

Acid2 2 #1988

Acid2 2 #1988

pcwalton commented Mar 28, 2014

highfive commented Mar 28, 2014

hoppipolla-critic-bot commented Mar 28, 2014

larsbergstrom commented Mar 28, 2014

pcwalton commented Mar 31, 2014

This comment has been minimized.

pcwalton commented on `9e3f7a0` Apr 3, 2014

This comment has been minimized.

larsbergstrom replied Apr 3, 2014

This comment has been minimized.

larsbergstrom replied Apr 4, 2014

This comment has been minimized.

bors-servo commented on `9e3f7a0` Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

servo / servo

Join GitHub today

Acid2 2 #1988

Acid2 2 #1988

Conversation

pcwalton commented Mar 28, 2014

highfive commented Mar 28, 2014

hoppipolla-critic-bot commented Mar 28, 2014

larsbergstrom commented Mar 28, 2014

pcwalton commented Mar 31, 2014

This comment has been minimized.

pcwalton commented on 9e3f7a0 Apr 3, 2014

This comment has been minimized.

larsbergstrom replied Apr 3, 2014

This comment has been minimized.

larsbergstrom replied Apr 4, 2014

This comment has been minimized.

bors-servo commented on 9e3f7a0 Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 3, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

This comment has been minimized.

bors-servo replied Apr 4, 2014

pcwalton commented on `9e3f7a0` Apr 3, 2014

bors-servo commented on `9e3f7a0` Apr 3, 2014