Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix mutation test in CI by passing env vars correctly #19884
Merged
Conversation
Originally, buildbot would try to directly execute `RUSTFLAGS=` as a binary since it was the first token in the command string, which won't work. Fix this by using the `env` command to set the environment variables, as there is currently no support for setting per-step environment variables in the `buildbot_steps.yml` file.
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jan 27, 2018
Fix mutation test in CI by passing env vars correctly Originally, buildbot would try to directly execute `RUSTFLAGS=` as a binary since it was the first token in the command string, which won't work. Fix this by using the `env` command to set the environment variables, as there is currently no support for setting per-step environment variables in the `buildbot_steps.yml` file. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes should fix #19821 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they change the CI configuration <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19884) <!-- Reviewable:end -->
|
|
|
Looks like the mutation test ran correctly this time (and found an error to boot): http://build.servo.org/builders/linux-rel-nogate/builds/1440/steps/shell__4/logs/stdio |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 28, 2018
Fix mutation test in CI by passing env vars correctly Originally, buildbot would try to directly execute `RUSTFLAGS=` as a binary since it was the first token in the command string, which won't work. Fix this by using the `env` command to set the environment variables, as there is currently no support for setting per-step environment variables in the `buildbot_steps.yml` file. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes should fix #19821 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they change the CI configuration <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19884) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedJan 27, 2018
•
edited by SimonSapin
Originally, buildbot would try to directly execute
RUSTFLAGS=as a binarysince it was the first token in the command string, which won't work.
Fix this by using the
envcommand to set the environment variables,as there is currently no support for setting per-step environment variables
in the
buildbot_steps.ymlfile../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is