Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Fix missing null terminator in error reporting code. #19915

Merged
merged 1 commit into from Jan 31, 2018
Merged

stylo: Fix missing null terminator in error reporting code. #19915

merged 1 commit into from Jan 31, 2018

Conversation

@emilio
Copy link
Member

emilio commented Jan 31, 2018 •
edited by SimonSapin

This was causing the patch in bug 1420026 to fail.

This change is Reviewable
@highfive
Copy link

highfive commented Jan 31, 2018

Heads up! This PR modifies the following files:

  • @bholley: ports/geckolib/error_reporter.rs, components/style/error_reporting.rs
  • @canaltinova: components/style/error_reporting.rs
@highfive
Copy link

highfive commented Jan 31, 2018

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Jan 31, 2018

r? @jdm or @upsuper or @bholley
@highfive highfive assigned jdm and unassigned Manishearth Jan 31, 2018
@jdm
Copy link
Member

jdm commented Jan 31, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2018

📌 Commit d88f171 has been approved by jdm
@emilio
stylo: Fix missing null terminators in error reporting code.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
d82c54b 
This was causing the patch in bug 1420026 to fail.
@emilio emilio force-pushed the emilio:color-errors-whee branch from d88f171 to d82c54b Jan 31, 2018
@emilio
Copy link
Member Author

emilio commented Jan 31, 2018

@bors-servo r=jdm

Fixed another one, yay c++
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2018

📌 Commit d82c54b has been approved by jdm
@jdm jdm mentioned this pull request Jan 31, 2018
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2018

⌛ Testing commit d82c54b with merge 4bd0590...
bors-servo added a commit that referenced this pull request Jan 31, 2018
@bors-servo
Auto merge of #19915 - emilio:color-errors-whee, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4bd0590 
stylo: Fix missing null terminator in error reporting code.

This was causing the patch in bug 1420026 to fail.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19915)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 4bd0590 to master...
@bors-servo bors-servo merged commit d82c54b into servo:master Jan 31, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@upsuper upsuper mentioned this pull request Feb 1, 2018
Merged
bors-servo added a commit that referenced this pull request Feb 4, 2018
@bors-servo
Auto merge of #19925 - upsuper:cstr, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9362d2b 
Use cstr macro for ffi literal strings

Use `cstr!()` macro with `CStr` to ensure that literal strings used with FFI is properly nul-terminated to avoid cases like #19915.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19925)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Feb 14, 2018
@bors-servo
Auto merge of #19925 - upsuper:cstr, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5af219e 
Use cstr macro for ffi literal strings

Use `cstr!()` macro with `CStr` to ensure that literal strings used with FFI is properly nul-terminated to avoid cases like #19915.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19925)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.