Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Mach bisect command #19943

Closed
wants to merge 3 commits into from
Closed

[WIP] Mach bisect command #19943

wants to merge 3 commits into from
+165 −17

Conversation

@o0Ignition0o
Copy link
Contributor

o0Ignition0o commented Feb 3, 2018 •
edited by jdm

This is a very rough beginning to handle #19505
This mainly allows me to share my code with @jdm and @atouchet for now.

Early comments are still more than welcome :)

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Feb 3, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon.
@highfive
Copy link

highfive commented Feb 3, 2018

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/mach_bootstrap.py, python/servo/bisect_commands.py
@o0Ignition0o o0Ignition0o force-pushed the o0Ignition0o:mach_bisect branch from 9f59138 to 1f9b2c0 Feb 3, 2018
@jdm jdm assigned jdm and unassigned wafflespeanut Mar 6, 2018
@aneeshusa aneeshusa requested review from frewsxcv and removed request for frewsxcv Mar 11, 2018
@aneeshusa
Copy link
Member

aneeshusa commented Mar 11, 2018

Sorry about that, misclicked.
o0Ignition0o added 2 commits Feb 3, 2018
@o0Ignition0o
First tryouts on a bisect command.
33d88e4
@o0Ignition0o
WIP : Rough first tries to download and cache nightly versions. Lots …
Loading status checks…
60395ef 
…of things are hardcoded for now in order to first make sure this works.
@o0Ignition0o o0Ignition0o force-pushed the o0Ignition0o:mach_bisect branch from 1f9b2c0 to 60395ef Dec 8, 2018
@o0Ignition0o
./mach run -n on mac os.
Loading status checks…
023520b
@o0Ignition0o o0Ignition0o force-pushed the o0Ignition0o:mach_bisect branch from 0ec8b81 to 023520b Dec 8, 2018
@jdm jdm removed the S-awaiting-review label Jun 28, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

☔ The latest upstream changes (presumably #24149) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2019

☔ The latest upstream changes (presumably #24198) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

☔ The latest upstream changes (presumably #24447) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2019

☔ The latest upstream changes (presumably #24575) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2020

☔ The latest upstream changes (presumably #25300) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2020

☔ The latest upstream changes (presumably #25853) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member

jdm commented Apr 20, 2020

Closing due to inactivity.
@jdm jdm closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-blocked-on-external S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@o0Ignition0o @highfive @aneeshusa @bors-servo @jdm @wafflespeanut
You can’t perform that action at this time.