Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Get rid of gecko_size_type. #19966

Merged
merged 5 commits into from Feb 7, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

style: Sprinkle some comments.

  • Loading branch information
emilio committed Feb 7, 2018
commit ed2ba30261726a7922225c990fc2c7bd2ad5bcad
@@ -164,7 +164,8 @@ ${helpers.predefined_type("order", "Integer", "0",
// FIXME: Gecko doesn't support content value yet.
//
// FIXME(emilio): I suspect this property shouldn't allow quirks, and this
// was just a mistake.
// was just a mistake, it's kind of justificable to support it given the
// spec grammar is just `content | <width>`, but other browsers don't...
${helpers.predefined_type(
"flex-basis",
"MozLength",
@@ -891,9 +891,15 @@ pub enum ExtremumLength {
impl ExtremumLength {
/// Returns whether this size keyword can be used for the given writing-mode
/// and property.
///
/// TODO: After these values are supported for both axes (and maybe
/// unprefixed, see bug 1322780) all this complexity can go away, and
/// everything can be derived (no need for uncacheable stuff).
fn valid_for(&self, wm: WritingMode, longhand: LonghandId) -> bool {
// We only make sense on the inline axis.
match longhand {
// FIXME(emilio): The flex-basis thing is not quite clear...
LonghandId::FlexBasis |
LonghandId::MinWidth |
LonghandId::MaxWidth |
LonghandId::Width => !wm.is_vertical(),
@@ -919,7 +925,9 @@ impl ExtremumLength {
}
}

/// A value suitable for a `min-width`, `min-height`, `width` or `height` property.
/// A value suitable for a `min-width`, `min-height`, `width` or `height`
/// property.
///
/// See values/specified/length.rs for more details.
#[allow(missing_docs)]
#[cfg_attr(feature = "servo", derive(MallocSizeOf))]
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.