Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix interpolation of the gecko-size properties. #19969

Merged
merged 1 commit into from Feb 7, 2018
Merged

style: Fix interpolation of the gecko-size properties. #19969

merged 1 commit into from Feb 7, 2018

Conversation

@emilio
Copy link
Member

emilio commented Feb 7, 2018 •
edited by SimonSapin

Followup to #19966 because, well...

The animation code should probably be more obvious.

This change is Reviewable
@emilio
style: Fix interpolation of the gecko-size properties.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
d9ae47c 
Followup to #19966 because, well...

The animation code should probably be more obvious.
@highfive
Copy link

highfive commented Feb 7, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/position.mako.rs
  • @canaltinova: components/style/properties/longhand/position.mako.rs
@highfive
Copy link

highfive commented Feb 7, 2018

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Feb 7, 2018

@bors-servo r+ p=10
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

📌 Commit d9ae47c has been approved by emilio
@highfive highfive assigned emilio and unassigned KiChjang Feb 7, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

⌛ Testing commit d9ae47c with merge cf4f89c...
bors-servo added a commit that referenced this pull request Feb 7, 2018
@bors-servo
Auto merge of #19969 - emilio:whoopsies, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cf4f89c 
style: Fix interpolation of the gecko-size properties.

Followup to #19966 because, well...

The animation code should probably be more obvious.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing cf4f89c to master...
@bors-servo bors-servo merged commit d9ae47c into servo:master Feb 7, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@emilio @highfive @bors-servo @KiChjang
You can’t perform that action at this time.