Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Optimize serialization of identifiers of length <= 16 🐉🐲 #19974

Merged
merged 1 commit into from Feb 7, 2018
Merged

style: Optimize serialization of identifiers of length <= 16 🐉🐲 #19974

merged 1 commit into from Feb 7, 2018

Conversation

@emilio
Copy link
Member

emilio commented Feb 7, 2018 •
edited by SimonSapin

Much like we optimize to_ascii_lowercase.

This change is Reviewable
@highfive
Copy link

highfive commented Feb 7, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets/font_feature_values_rule.rs, components/style/gecko_string_cache/mod.rs, components/style/values/mod.rs, components/style/values/specified/mod.rs, components/style/values/computed/font.rs and 2 more
  • @canaltinova: components/style/stylesheets/font_feature_values_rule.rs, components/style/gecko_string_cache/mod.rs, components/style/values/mod.rs, components/style/values/specified/mod.rs, components/style/values/computed/font.rs and 2 more
@highfive
Copy link

highfive commented Feb 7, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Feb 7, 2018

r=me with a green geckotry. Nice dragoning.
@emilio
Copy link
Member Author

emilio commented Feb 7, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

📌 Commit fc3911e has been approved by nox
@highfive highfive assigned nox and unassigned pcwalton Feb 7, 2018
@jdm
Copy link
Member

jdm commented Feb 7, 2018

@bors-servo r-
Fails test-tidy and fails ./mach build.
@emilio emilio force-pushed the emilio:atom-serialization branch from fc3911e to e0df617 Feb 7, 2018
@emilio
Copy link
Member Author

emilio commented Feb 7, 2018

Thanks @jdm, fixed
@emilio
Copy link
Member Author

emilio commented Feb 7, 2018

@bors-servo try

  • I'll add a test for the unknown namespace thingie if there isn't one.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

⌛ Trying commit e0df617 with merge e52d9d5...
bors-servo added a commit that referenced this pull request Feb 7, 2018
@bors-servo
Auto merge of #19974 - emilio:atom-serialization, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e52d9d5 
style: Optimize serialization of identifiers of length <= 16 🐉🐲

Much like we optimize to_ascii_lowercase.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19974)
<!-- Reviewable:end -->
@emilio
Copy link
Member Author

emilio commented Feb 7, 2018

@bors-servo r=nox

  • Upon reflection servo doesn't support generated content with namespaced attributes...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

📌 Commit e0df617 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

⌛ Testing commit e0df617 with merge eca4328...
bors-servo added a commit that referenced this pull request Feb 7, 2018
@bors-servo
Auto merge of #19974 - emilio:atom-serialization, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eca4328 
style: Optimize serialization of identifiers of length <= 16 🐉🐲

Much like we optimize to_ascii_lowercase.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19974)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

💔 Test failed - linux-dev
@emilio
style: Optimize serialization of identifiers of length <= 16 🐉🐲
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
f4c9c59 
Much like we optimize to_ascii_lowercase.

This also fixes a bug in Servo where attr() rules with an unknown namespace
prefix are parsed, which is wrong.
@emilio emilio force-pushed the emilio:atom-serialization branch from e0df617 to f4c9c59 Feb 7, 2018
@emilio
Copy link
Member Author

emilio commented Feb 7, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

📌 Commit f4c9c59 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

⌛ Testing commit f4c9c59 with merge b55cce7...
bors-servo added a commit that referenced this pull request Feb 7, 2018
@bors-servo
Auto merge of #19974 - emilio:atom-serialization, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b55cce7 
style: Optimize serialization of identifiers of length <= 16 🐉🐲

Much like we optimize to_ascii_lowercase.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19974)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Feb 7, 2018

@bors-servo retry
#13479
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

⌛ Testing commit f4c9c59 with merge a0e4ea9...
bors-servo added a commit that referenced this pull request Feb 7, 2018
@bors-servo
Auto merge of #19974 - emilio:atom-serialization, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a0e4ea9 
style: Optimize serialization of identifiers of length <= 16 🐉🐲

Much like we optimize to_ascii_lowercase.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19974)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing a0e4ea9 to master...
@bors-servo bors-servo merged commit f4c9c59 into servo:master Feb 7, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 7, 2018
Closed
4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-fails-tidy
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @nox @bors-servo @jdm @pcwalton
You can’t perform that action at this time.