Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate syn, quote and synstructure #20022
Conversation
highfive
commented
Feb 11, 2018
|
Heads up! This PR modifies the following files:
|
|
Fourth commit says it's about malloc_size_of_derive, but it also updates style_derive. Could you split the two and merge the "make tidy happy" commit be squashed with the commit that introduced the tidy failures? |
|
I reviewed the three first commits, will review the two last later. |
| @@ -2,27 +2,29 @@ | |||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| #![recursion_limit = "128"] | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Eijebong
Feb 12, 2018
Author
Member
Because quote! recurses heavily and it failed to compile without this
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Eijebong
Feb 12, 2018
Author
Member
Doesn't compile without it, if that's a problem I guess I could split the quote! invocation in 2...
error: recursion limit reached while expanding the macro `stringify`
--> components/domobject_derive/lib.rs:36:21
|
36 | let mut items = quote! {
| _____________________^
37 | | impl #impl_generics ::js::conversions::ToJSValConvertible for #name #ty_generics #where_clause {
38 | | #[allow(unsafe_code)]
39 | | unsafe fn to_jsval(&self,
... |
58 | | }
59 | | };
| |_____^
| syn = "0.11" | ||
| quote = "0.3.15" | ||
| syn = "0.12" | ||
| quote = "0.4" |
This comment has been minimized.
This comment has been minimized.
nox
Feb 12, 2018
Member
You sure about these versions, and that you don't require anything introduced in a minor release of either? Note that Gecko will use exactly 0.12 and 0.4 and thus it could fail to compile there. Just to be safe I would recommend setting the lowest bounds to 0.12.12 and 0.4.2.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
Update syn, quote and synstructure Right now they're duplicated because we need a new serde release (ping @dtolnay), a new cssparser release (ping @SimonSapin) and a new release of html5ever with servo/html5ever#336 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20022) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
Update syn, quote and synstructure Right now they're duplicated because we need a new serde release (ping @dtolnay), a new cssparser release (ping @SimonSapin) and a new release of html5ever with servo/html5ever#336 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20022) <!-- Reviewable:end -->
|
|
Eijebong commentedFeb 11, 2018
•
edited by SimonSapin
Right now they're duplicated because we need a new serde release (ping @dtolnay), a new cssparser release (ping @SimonSapin) and a new release of html5ever with servo/html5ever#336
This change is